paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 17:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Initialize stream list code in stream_list.js.

Browse Source 
This code was in subs.js for historical reasons.
This commit is contained in:
Steve Howell
2019-03-22 16:26:51 +00:00
committed by Tim Abbott
parent d8e9975b9d
commit bfdce11c8f
4 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
frontend_tests/node_tests/stream_list.js
View File

@@ -280,7 +280,7 @@ run_test('zoom_in_and_zoom_out', () => {
f.call(elem(stream_li1)); f.call(elem(stream_li1));
f.call(elem(stream_li2)); f.call(elem(stream_li2));
}; };
stream_list.initialize(); stream_list.set_event_handlers();
stream_list.zoom_in_topics({stream_id: 42}); stream_list.zoom_in_topics({stream_id: 42});
@@ -337,7 +337,7 @@ run_test('narrowing', () => {
assert(!$('<devel sidebar row html>').hasClass('active-filter')); assert(!$('<devel sidebar row html>').hasClass('active-filter'));
stream_list.initialize(); stream_list.set_event_handlers();
var filter; var filter;

9
static/js/stream_list.js
View File

@@ -468,6 +468,15 @@ function actually_update_streams_for_search() {
var update_streams_for_search = _.throttle(actually_update_streams_for_search, 50); var update_streams_for_search = _.throttle(actually_update_streams_for_search, 50);
exports.initialize = function () { exports.initialize = function () {
stream_list.create_initial_sidebar_rows();
// We build the stream_list now. It may get re-built again very shortly
// when new messages come in, but it's fairly quick.
stream_list.build_stream_list();
exports.set_event_handlers();
};
exports.set_event_handlers = function () {
$(document).on('subscription_add_done.zulip', function (event) { $(document).on('subscription_add_done.zulip', function (event) {
exports.create_sidebar_row(event.sub); exports.create_sidebar_row(event.sub);
exports.build_stream_list(); exports.build_stream_list();

6
static/js/subs.js
View File

@@ -828,12 +828,6 @@ exports.sub_or_unsub = function (sub) {
exports.initialize = function () { exports.initialize = function () {
stream_list.create_initial_sidebar_rows();
// We build the stream_list now. It may get re-built again very shortly
// when new messages come in, but it's fairly quick.
stream_list.build_stream_list();
add_email_hint_handler(); add_email_hint_handler();
$("#subscriptions_table").on("click", ".create_stream_button", function (e) { $("#subscriptions_table").on("click", ".create_stream_button", function (e) {

2
static/js/ui_init.js
View File

@@ -286,6 +286,7 @@ exports.initialize_everything = function () {
stream_data.initialize(); stream_data.initialize();
muting.initialize(); muting.initialize();
subs.initialize(); subs.initialize();
stream_list.initialize();
condense.initialize(); condense.initialize();
lightbox.initialize(); lightbox.initialize();
click_handlers.initialize(); click_handlers.initialize();
@@ -324,7 +325,6 @@ exports.initialize_everything = function () {
emoji_picker.initialize(); emoji_picker.initialize();
compose_fade.initialize(); compose_fade.initialize();
pm_list.initialize(); pm_list.initialize();
stream_list.initialize();
topic_list.initialize(); topic_list.initialize();
topic_zoom.initialize(); topic_zoom.initialize();
drafts.initialize(); drafts.initialize();