mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 05:53:43 +00:00 
			
		
		
		
	trello: Ignore updateCheckItem/updateList actions.
This commit is contained in:
		@@ -112,21 +112,26 @@ class TrelloHookTests(WebhookTestCase):
 | 
			
		||||
        payload = self.get_body('change_board_background_image')
 | 
			
		||||
        self.verify_post_is_ignored(payload)
 | 
			
		||||
 | 
			
		||||
    def test_create_card_check_item_ignore(self) -> None:
 | 
			
		||||
    def test_ignored_card_actions(self) -> None:
 | 
			
		||||
        """
 | 
			
		||||
        Certain card-related actions are now ignored solely based on the
 | 
			
		||||
        action type, and we don't need to do any other parsing to ignore
 | 
			
		||||
        them as invalid.
 | 
			
		||||
        """
 | 
			
		||||
        action = "createCheckItem"
 | 
			
		||||
        data = dict(
 | 
			
		||||
            model="whatever",
 | 
			
		||||
            action=dict(
 | 
			
		||||
                type=action,
 | 
			
		||||
            ),
 | 
			
		||||
        )
 | 
			
		||||
        payload = orjson.dumps(data).decode()
 | 
			
		||||
        self.verify_post_is_ignored(payload)
 | 
			
		||||
        actions = [
 | 
			
		||||
            "createCheckItem",
 | 
			
		||||
            "updateCheckItem",
 | 
			
		||||
            "updateList",
 | 
			
		||||
        ]
 | 
			
		||||
        for action in actions:
 | 
			
		||||
            data = dict(
 | 
			
		||||
                model="whatever",
 | 
			
		||||
                action=dict(
 | 
			
		||||
                    type=action,
 | 
			
		||||
                ),
 | 
			
		||||
            )
 | 
			
		||||
            payload = orjson.dumps(data).decode()
 | 
			
		||||
            self.verify_post_is_ignored(payload)
 | 
			
		||||
 | 
			
		||||
    def test_trello_webhook_when_description_was_added_to_card(self) -> None:
 | 
			
		||||
        expected_message = "Marco Matarazzo set description for [New Card](https://trello.com/c/P2r0z66z) to:\n~~~ quote\nNew Description\n~~~"
 | 
			
		||||
 
 | 
			
		||||
@@ -16,7 +16,9 @@ SUPPORTED_CARD_ACTIONS = [
 | 
			
		||||
]
 | 
			
		||||
 | 
			
		||||
IGNORED_CARD_ACTIONS = [
 | 
			
		||||
    'createCheckItem',
 | 
			
		||||
    "createCheckItem",
 | 
			
		||||
    "updateCheckItem",
 | 
			
		||||
    "updateList",
 | 
			
		||||
]
 | 
			
		||||
 | 
			
		||||
CREATE = 'createCard'
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user