From c06565d90994107bfe2abb911fd95d027dc82d9f Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Wed, 4 Apr 2018 16:31:30 -0700 Subject: [PATCH] users: Improve testing for user_ids_to_users. --- zerver/lib/users.py | 2 +- zerver/tests/test_users.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/zerver/lib/users.py b/zerver/lib/users.py index 6925a40e2f..ac5a013aad 100644 --- a/zerver/lib/users.py +++ b/zerver/lib/users.py @@ -109,7 +109,7 @@ def user_ids_to_users(user_ids: List[int], realm: Realm) -> List[UserProfile]: # users should be included. def fetch_users_by_id(user_ids: List[int]) -> List[UserProfile]: - if not user_ids: + if len(user_ids) == 0: return [] return list(UserProfile.objects.filter(id__in=user_ids).select_related()) diff --git a/zerver/tests/test_users.py b/zerver/tests/test_users.py index 73edcac5ed..6088b787f7 100644 --- a/zerver/tests/test_users.py +++ b/zerver/tests/test_users.py @@ -286,7 +286,9 @@ class UserProfileTest(ZulipTestCase): self.example_user('cordelia').id, ] - user_ids_to_users(real_user_ids, get_realm("zulip")) + self.assertEqual(user_ids_to_users([], get_realm("zulip")), []) + self.assertEqual(set([user_profile.id for user_profile in user_ids_to_users(real_user_ids, get_realm("zulip"))]), + set(real_user_ids)) with self.assertRaises(JsonableError): user_ids_to_users([1234], get_realm("zephyr")) with self.assertRaises(JsonableError):