paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

emoji: Move EMOTICON_CONVERSIONS mapping to build_emoji infra.

Browse Source 
This commit closes a long pending issue which involved moving the
`EMOTICON_CONVERSION` mapping to build_emoji infrastructure so
that there is only one source of truth. This was pending from the
time when this feature was implemented.
This commit is contained in:
Harshit Bansal
2018-07-20 09:37:39 +00:00
committed by Tim Abbott
parent 565fd75661
commit c0b0fb7cce
6 changed files with 39 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend_tests/node_tests/emoji.js
View File

@@ -50,6 +50,7 @@ run_test('get_canonical_name', () => {
var canonical_name = emoji.get_canonical_name('realm_emoji');
assert.equal(canonical_name, 'realm_emoji');
var orig_emoji_codes = global.emoji_codes;
global.emoji_codes = {
name_to_codepoint: {
'+1': '1f44d',
@@ -71,6 +72,7 @@ run_test('get_canonical_name', () => {
emoji.get_canonical_name('non_existent');
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();
global.emoji_codes = orig_emoji_codes;
});
run_test('translate_emoticons_to_names', () => {
@@ -95,9 +97,9 @@ run_test('translate_emoticons_to_names', () => {
{name: 'between symbols', original: 'Hello.<original>! World.', expected: 'Hello.<original>! World.'},
{name: 'before end of sentence', original: 'Hello <original>!', expected: 'Hello <converted>!'},
];
_.each(emoji.EMOTICON_CONVERSIONS, (full_name, shortcut) => {
_.each(emoji_codes.emoticon_conversions, (full_name, shortcut) => {
_.each(testcases, (t) => {
var converted_value = ':' + full_name + ':';
var converted_value = full_name;
var original = t.original;
var expected = t.expected;
original = original.replace(/(<original>)/g, shortcut);