paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 00:46:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove product_name setting and return to harcoding 'Zulip'.

Browse Source 
This removes some confusion in grep for frontend strings with Zulip in
them and also cleans up the code in some places.

Fixes #1602.
This commit is contained in:
Raghav Jajodia
2017-02-22 01:14:43 +05:30
committed by Tim Abbott
parent 60296c022c
commit c17e574211
17 changed files with 25 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/notifications.js
View File

@@ -148,7 +148,7 @@ exports.redraw_title = function () {
var new_title = (new_message_count ? ("(" + new_message_count + ") ") : "")
+ narrow.narrow_title + " - "
+ page_params.realm_name + " - "
+ page_params.product_name;
+ "Zulip";
if (document.title === new_title) {
return;

6
static/js/tutorial.js
View File

@@ -366,8 +366,8 @@ function finale(skip) {
if (stream_data.in_home_view(page_params.notifications_stream)) {
send_delayed_stream_message(page_params.notifications_stream, "welcome", "Practice sending sending some messages here, or starting a new topic.", 15);
send_delayed_stream_message(page_params.notifications_stream, page_params.product_name + " tips", "Here's a message on a new topic: `" + page_params.product_name + " tips`.\n\nAs you settle into " + page_params.product_name + ", customize your account and notifications on your [Settings page](#settings).", 30);
send_delayed_stream_message(page_params.notifications_stream, page_params.product_name + " tips", "You might also enjoy:\n\n* Our lightweight !modal_link(#markdown-help, message formatting) (including emoji! :thumbsup:)\n* !modal_link(#keyboard-shortcuts, Keyboard shortcuts)\n* [Desktop and mobile apps](/apps)", 40);
send_delayed_stream_message(page_params.notifications_stream, "Zulip tips", "Here's a message on a new topic: `Zulip tips`.\n\nAs you settle into Zulip, customize your account and notifications on your [Settings page](#settings).", 30);
send_delayed_stream_message(page_params.notifications_stream, "Zulip tips", "You might also enjoy:\n\n* Our lightweight !modal_link(#markdown-help, message formatting) (including emoji! :thumbsup:)\n* !modal_link(#keyboard-shortcuts, Keyboard shortcuts)\n* [Desktop and mobile apps](/apps)", 40);
}
if (work_stream !== undefined) {
@@ -486,7 +486,7 @@ function welcome() {
var spotlight_message = rows.first_visible();
var bar = rows.get_message_recipient_header(spotlight_message);
box_first_message();
create_and_show_popover(bar, maybe_tweak_placement("left"), "Welcome to " + page_params.product_name,
create_and_show_popover(bar, maybe_tweak_placement("left"), "Welcome to Zulip",
"tutorial_message");
var my_popover = $("#tutorial-message").closest(".popover");