paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

mypy: Fix strict-optional errors in webhooks directory.

Browse Source
This commit is contained in:
umkay
2017-05-24 14:03:06 -07:00
committed by Tim Abbott
parent 8ab6a23a30
commit c1a8fb615c
14 changed files with 104 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
zerver/webhooks/github/view.py
View File

@@ -137,7 +137,8 @@ def api_github_v2(user_profile, event, payload, branches, default_stream,
target_stream = commit_stream if commit_stream else default_stream
issue_stream = issue_stream if issue_stream else default_stream
repository = payload['repository']
topic_focus = topic_focus if topic_focus else repository['name']
updated_topic_focus = topic_focus if topic_focus else repository['name']
# Event Handlers
if event == 'pull_request':
@@ -166,7 +167,7 @@ def api_github_v2(user_profile, event, payload, branches, default_stream,
content = github_object_commented_content(payload, type)
elif event == 'push':
subject, content = build_message_from_gitlog(user_profile, topic_focus,
subject, content = build_message_from_gitlog(user_profile, updated_topic_focus,
payload['ref'], payload['commits'],
payload['before'], payload['after'],
payload['compare'],
@@ -175,9 +176,9 @@ def api_github_v2(user_profile, event, payload, branches, default_stream,
created=payload['created'],
deleted=payload['deleted'])
elif event == 'commit_comment':
subject = topic_focus
subject = updated_topic_focus
comment = payload.get('comment')
comment = payload['comment']
action = u'[commented]({})'.format(comment['html_url'])
content = get_commits_comment_action_message(
comment['user']['login'],
@@ -301,7 +302,7 @@ def _transform_commits_list_to_common_format(commits):
new_commits_list = []
for commit in commits:
new_commits_list.append({
'name': commit.get('author').get('username'),
'name': commit['author'].get('username'),
'sha': commit.get('id'),
'url': commit.get('url'),
'message': commit.get('message'),