paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Only require stream_id in private_stream_user_ids().

Browse Source
This commit is contained in:
Steve Howell
2017-09-17 12:48:23 -07:00
committed by Tim Abbott
parent 7dbea8a2bf
commit c1d7fc6e80
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/lib/actions.py
View File

@@ -153,15 +153,15 @@ def can_access_stream_user_ids(stream):
if stream.is_public(): if stream.is_public():
return set(active_user_ids(stream.realm_id)) return set(active_user_ids(stream.realm_id))
else: else:
return private_stream_user_ids(stream) return private_stream_user_ids(stream.id)
def private_stream_user_ids(stream): def private_stream_user_ids(stream_id):
# type: (Stream) -> Set[int] # type: (int) -> Set[int]
# TODO: Find similar queries elsewhere and de-duplicate this code. # TODO: Find similar queries elsewhere and de-duplicate this code.
subscriptions = Subscription.objects.filter( subscriptions = Subscription.objects.filter(
recipient__type=Recipient.STREAM, recipient__type=Recipient.STREAM,
recipient__type_id=stream.id, recipient__type_id=stream_id,
active=True) active=True)
return {sub['user_profile_id'] for sub in subscriptions.values('user_profile_id')} return {sub['user_profile_id'] for sub in subscriptions.values('user_profile_id')}