paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add linter checks for javascript strings and HTML placeholders.

Browse Source 
Checks are added for:
- i18n.t
- placeholder
- compose_error
This commit is contained in:
Umair Khan
2016-06-13 13:23:20 +05:00
committed by Tim Abbott
parent 6fcfed8d9e
commit c1f5ac375c
1 changed files with 14 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
tools/lint-all
View File

@@ -155,6 +155,14 @@ js_rules = [
'description': 'Write JS else statements on same line as }'}, 'description': 'Write JS else statements on same line as }'},
{'pattern': '^else if', {'pattern': '^else if',
'description': 'Write JS else statements on same line as }'}, 'description': 'Write JS else statements on same line as }'},
{'pattern': 'button\.text\(["\']',
'exclude': set(['tools/lint-all',
'frontend_tests/node_tests/templates.js']),
'description': 'Argument to button.text should be a literal string enclosed by i18n.t()'},
{'pattern': 'compose_error\(["\']',
'exclude': set(['tools/lint-all']),
'description': 'Argument to compose_error should be a literal string enclosed '
'by i18n.t()'},
] + whitespace_rules ] + whitespace_rules
python_rules = [ python_rules = [
{'pattern': '^(?!#)@login_required', {'pattern': '^(?!#)@login_required',
@@ -245,7 +253,12 @@ css_rules = [
'description': "Missing whitespace after '{' in CSS (should be newline)."}, 'description': "Missing whitespace after '{' in CSS (should be newline)."},
] + whitespace_rules ] + whitespace_rules
handlebars_rules = whitespace_rules handlebars_rules = whitespace_rules
html_rules = whitespace_rules html_rules = whitespace_rules + [
{'pattern': 'placeholder="[^{]',
'description': "`placeholder` value should be translatable."},
{'pattern': "placeholder='[^{]",
'description': "`placeholder` value should be translatable."},
]
json_rules = [] # just fix newlines at ends of files json_rules = [] # just fix newlines at ends of files
markdown_rules = whitespace_rules markdown_rules = whitespace_rules
txt_rules = whitespace_rules txt_rules = whitespace_rules