paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

custom profile fields: Cleanup event generation logic.

Browse Source 
In my opinion, this makes the code somewhat more readable.
This commit is contained in:
Tim Abbott
2018-08-22 22:44:39 -07:00
parent b5fb110166
commit c313a939f7
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
zerver/lib/actions.py
View File

@@ -4907,14 +4907,15 @@ def notify_user_update_custom_profile_data(user_profile: UserProfile,
def do_update_user_custom_profile_data(user_profile: UserProfile, def do_update_user_custom_profile_data(user_profile: UserProfile,
data: List[Dict[str, Union[int, str, List[int]]]]) -> None: data: List[Dict[str, Union[int, str, List[int]]]]) -> None:
with transaction.atomic(): with transaction.atomic():
update_or_create = CustomProfileFieldValue.objects.update_or_create
for field in data: for field in data:
field_value, created = update_or_create(user_profile=user_profile, field_value, created = CustomProfileFieldValue.objects.update_or_create(
field_id=field['id'], user_profile=user_profile,
defaults={'value': field['value']}) field_id=field['id'],
notify_user_update_custom_profile_data(user_profile, {"id": field['id'], defaults={'value': field['value']})
"value": field['value'], notify_user_update_custom_profile_data(user_profile, {
"type": field_value.field.field_type}) "id": field_value.field_id,
"value": field_value.value,
"type": field_value.field.field_type})
def do_send_create_user_group_event(user_group: UserGroup, members: List[UserProfile]) -> None: def do_send_create_user_group_event(user_group: UserGroup, members: List[UserProfile]) -> None:
event = dict(type="user_group", event = dict(type="user_group",