paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_openapi: Fix confused error messages for missing parameters.

Browse Source 
These conditionals were backwards.
This commit is contained in:
Tim Abbott
2019-10-21 16:26:08 -07:00
parent c120ce6ecc
commit c35472e025
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/tests/test_openapi.py
View File

@@ -540,13 +540,13 @@ so maybe we shouldn't include it in pending_endpoints.
[parameter['name'] for parameter in openapi_parameters]
)
if len(openapi_parameter_names - accepted_arguments) > 0:
if len(accepted_arguments - openapi_parameter_names) > 0:
print("Undocumented parameters for",
url_pattern, method, function_name)
print(" +", openapi_parameter_names)
print(" -", accepted_arguments)
assert(url_pattern in self.buggy_documentation_endpoints)
elif len(accepted_arguments - openapi_parameter_names) > 0: # nocoverage
elif len(openapi_parameter_names - accepted_arguments) > 0: # nocoverage
print("Documented invalid parameters for",
url_pattern, method, function_name)
print(" -", openapi_parameter_names)