mirror of
				https://github.com/zulip/zulip.git
				synced 2025-11-04 05:53:43 +00:00 
			
		
		
		
	bots: Fix unit tests not running in Vagrant.
`test-bots` would not run in Vagrant, displaying the error "ValueError: no such test method in <class 'bots_test_lib.BotTestCase'>: runTest" This was due to the `BotTestCase` class inheriting from the TestCase class, even though it was not a unit test on its own. This commit removes the inheritance of TestCase and specifies `test_define` as the `runTest` method in `TestDefineBot`.
This commit is contained in:
		@@ -42,7 +42,7 @@ class TestDefineBot(TestCase):
 | 
			
		||||
        messages.append(message2)
 | 
			
		||||
        return messages
 | 
			
		||||
 | 
			
		||||
    def test_define(self):
 | 
			
		||||
    def runTest(self):
 | 
			
		||||
        # type: None -> None
 | 
			
		||||
        # Edit bot_module to test different bots, the below code can be looped for all the bots.
 | 
			
		||||
        bot_module = os.path.join(our_dir, "define.py")
 | 
			
		||||
 
 | 
			
		||||
@@ -8,14 +8,13 @@ import sys
 | 
			
		||||
import unittest
 | 
			
		||||
 | 
			
		||||
from mock import MagicMock, patch
 | 
			
		||||
from unittest import TestCase
 | 
			
		||||
 | 
			
		||||
from run import get_lib_module
 | 
			
		||||
from bot_lib import StateHandler
 | 
			
		||||
from contrib_bots import bot_lib
 | 
			
		||||
from six.moves import zip
 | 
			
		||||
 | 
			
		||||
class BotTestCase(TestCase):
 | 
			
		||||
class BotTestCase():
 | 
			
		||||
 | 
			
		||||
    def mock_test(self, messages, message_handler, bot_response):
 | 
			
		||||
        # type: (List[Dict[str, str]], Function) -> None
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user