paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 16:43:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

stripe: Rename @error_handler decorator.

Browse Source 
This decorator, among other things, transforms the "event" argument
passed when calling the decorated functions into actually passing
event.content_object.

So e.g. despite having a (before the decorator is applied) signature:

```
def handle_invoice_paid_event(stripe_invoice: stripe.Invoice, invoice: Invoice) -> None:
```

these are called passing an `Event` in the second arg when calling
`handle_invoice_paid_event`:

```
handle_invoice_paid_event(stripe_invoice, event)
```

I found that kind of confusing because the @error_handler decorator
didn't sound like something that would intervene in the arguments like
that. So it feels helpful to rename it something with a less modest
name, that makes it sound like it does more than just pure
error-handling.
This commit is contained in:
Mateusz Mandera
2024-03-28 03:53:16 +01:00
committed by Tim Abbott
parent db1f69e72f
commit c3caa3ecc8
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
corporate/lib/stripe_event_handler.py
View File

@@ -19,7 +19,7 @@ from zerver.models.users import get_active_user_profile_by_id_in_realm
billing_logger = logging.getLogger("corporate.stripe") billing_logger = logging.getLogger("corporate.stripe")
def error_handler( def stripe_event_handler_decorator(
func: Callable[[Any, Any], None], func: Callable[[Any, Any], None],
) -> Callable[[Union[stripe.checkout.Session, stripe.Invoice], Event], None]: ) -> Callable[[Union[stripe.checkout.Session, stripe.Invoice], Event], None]:
def wrapper( def wrapper(
@@ -90,7 +90,7 @@ def get_billing_session_for_stripe_webhook(
return RealmBillingSession(user) return RealmBillingSession(user)
@error_handler @stripe_event_handler_decorator
def handle_checkout_session_completed_event( def handle_checkout_session_completed_event(
stripe_session: stripe.checkout.Session, session: Session stripe_session: stripe.checkout.Session, session: Session
) -> None: ) -> None:
@@ -113,7 +113,7 @@ def handle_checkout_session_completed_event(
billing_session.update_or_create_stripe_customer(payment_method) billing_session.update_or_create_stripe_customer(payment_method)
@error_handler @stripe_event_handler_decorator
def handle_invoice_paid_event(stripe_invoice: stripe.Invoice, invoice: Invoice) -> None: def handle_invoice_paid_event(stripe_invoice: stripe.Invoice, invoice: Invoice) -> None:
invoice.status = Invoice.PAID invoice.status = Invoice.PAID
invoice.save(update_fields=["status"]) invoice.save(update_fields=["status"])