paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

right-sidebar: Added clear-search button on user-list searchbar.

Browse Source 
A clear-search option to clear the user-list searchbox has been added.
This feature was present in the main searchbar but absent elsewhere.
Fix a part of #3716.
This commit is contained in:
Raghav Jajodia
2017-02-18 21:38:28 +05:30
committed by Tim Abbott
parent 233c5eb255
commit c3dbce810e
4 changed files with 63 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
static/js/activity.js
View File

@@ -520,6 +520,17 @@ exports.searching = function () {
return $('.user-list-filter').expectOne().is(':focus');
};
function update_clear_search_button() {
var focused = $('.user-list-filter').is(':focus');
// Show button iff the search input is focused, or has non-empty contents
if (focused || $('.user-list-filter').val()) {
$('#clear_search_people_button').removeAttr('disabled');
} else {
$('#clear_search_people_button').attr('disabled', 'disabled');
}
}
exports.escape_search = function () {
var filter = $('.user-list-filter').expectOne();
if (filter.val() === '') {
@@ -527,6 +538,7 @@ exports.escape_search = function () {
return;
}
filter.val('');
update_clear_search_button();
update_users_for_search();
};
@@ -537,6 +549,14 @@ exports.initiate_search = function () {
exports.blur_search = function () {
$('.user-list-filter').blur();
update_clear_search_button();
};
exports.clear_search = function () {
$('.user-list-filter').val('');
$('.user-list-filter').blur();
update_clear_search_button();
update_users_for_search();
};
function maybe_select_person(e) {
@@ -562,13 +582,16 @@ function maybe_select_person(e) {
function focus_user_filter(e) {
e.stopPropagation();
update_clear_search_button();
}
$(function () {
$(".user-list-filter").expectOne()
.on('click', focus_user_filter)
.on('input', update_users_for_search)
.on('keydown', maybe_select_person);
.on('keydown', maybe_select_person)
.on('blur', update_clear_search_button);
$('#clear_search_people_button').on('click', exports.clear_search);
});