paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_popover: Fix rename topic placeholder UI.

Browse Source 
Previously, the placeholder in the "Rename topic" input
overlapped with the text when renaming the "general chat"
topic. Also, the placeholder was not updated to "general chat"
when the input was empty and lost focus. This commit fixes the bug.
This commit is contained in:
Vector73
2025-06-19 12:05:40 +00:00
committed by Tim Abbott
parent 8400c24665
commit c406db2480
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/stream_popover.ts
View File

@@ -924,14 +924,12 @@ export async function build_move_topic_to_stream_popover(
}
function update_topic_input_placeholder_visibility(topic_input_value: string): void {
if (stream_data.can_use_empty_topic(stream_widget_value)) {
const $topic_not_mandatory_placeholder = $(".move-topic-new-topic-placeholder");
$topic_not_mandatory_placeholder.toggleClass(
"move-topic-new-topic-placeholder-visible",
topic_input_value === "",
topic_input_value === "" && stream_data.can_use_empty_topic(stream_widget_value),
);
}
}
function setup_resize_observer($topic_input: JQuery<HTMLInputElement>): void {
// Update position of topic typeahead because showing/hiding the
@@ -1010,6 +1008,7 @@ export async function build_move_topic_to_stream_popover(
move_topic_to_stream_topic_typeahead?.hide();
});
stream_widget_value = current_stream_id;
if (only_topic_edit) {
// Set select_stream_id to current_stream_id since user is not allowed
// to edit stream in topic-edit only UI.
@@ -1025,7 +1024,6 @@ export async function build_move_topic_to_stream_popover(
return;
}
stream_widget_value = current_stream_id;
const streams_list_options = (): dropdown_widget.Option[] =>
stream_data.get_streams_for_move_messages_widget().filter(({stream}) => {
if (stream.stream_id === current_stream_id) {