paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

test_mattermost_importer: Fix missing coverage.

Browse Source
This commit is contained in:
Wyatt Hoodes
2019-08-20 12:16:34 -10:00
committed by Tim Abbott
parent 26f7dd09ce
commit c48e53f587
1 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
zerver/tests/test_mattermost_importer.py
View File

@@ -80,6 +80,11 @@ class MatterMostImporter(ZulipTestCase):
self.assertEqual(user["short_name"], "harry") self.assertEqual(user["short_name"], "harry")
self.assertEqual(user["timezone"], "UTC") self.assertEqual(user["timezone"], "UTC")
# A user with a `null` team value shouldn't be an admin.
harry_dict["teams"] = None
user = process_user(harry_dict, realm_id, team_name, user_id_mapper)
self.assertEqual(user["is_realm_admin"], False)
team_name = "slytherin" team_name = "slytherin"
snape_dict = self.username_to_user["snape"] snape_dict = self.username_to_user["snape"]
snape_dict["is_mirror_dummy"] = True snape_dict["is_mirror_dummy"] = True
@@ -184,6 +189,21 @@ class MatterMostImporter(ZulipTestCase):
self.assertEqual(subscriber_handler.get_users(stream_id_mapper.get("gryffindor-quidditch-team")), {1, 2}) self.assertEqual(subscriber_handler.get_users(stream_id_mapper.get("gryffindor-quidditch-team")), {1, 2})
self.assertEqual(subscriber_handler.get_users(stream_id_mapper.get("dumbledores-army")), {1, 2}) self.assertEqual(subscriber_handler.get_users(stream_id_mapper.get("dumbledores-army")), {1, 2})
# Converting channel data when a user's `teams` value is `null`.
self.username_to_user["ron"].update({"teams": None})
zerver_stream = convert_channel_data(
channel_data=self.mattermost_data["channel"],
user_data_map=self.username_to_user,
subscriber_handler=subscriber_handler,
stream_id_mapper=stream_id_mapper,
user_id_mapper=user_id_mapper,
realm_id=4,
team_name=team_name,
)
self.assertEqual(subscriber_handler.get_users(stream_id_mapper.get("gryffindor-common-room")), {2, 2})
self.assertEqual(subscriber_handler.get_users(stream_id_mapper.get("gryffindor-quidditch-team")), {2, 2})
self.assertEqual(subscriber_handler.get_users(stream_id_mapper.get("dumbledores-army")), {2, 2})
team_name = "slytherin" team_name = "slytherin"
zerver_stream = convert_channel_data( zerver_stream = convert_channel_data(
channel_data=self.mattermost_data["channel"], channel_data=self.mattermost_data["channel"],
@@ -313,6 +333,9 @@ class MatterMostImporter(ZulipTestCase):
self.assertFalse(check_user_in_team(snape, "gryffindor")) self.assertFalse(check_user_in_team(snape, "gryffindor"))
self.assertTrue(check_user_in_team(snape, "slytherin")) self.assertTrue(check_user_in_team(snape, "slytherin"))
snape.update({"teams": None})
self.assertFalse(check_user_in_team(snape, "slytherin"))
def test_label_mirror_dummy_users(self) -> None: def test_label_mirror_dummy_users(self) -> None:
label_mirror_dummy_users( label_mirror_dummy_users(
team_name="gryffindor", team_name="gryffindor",