paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move more code into activate_section().

Browse Source 
This code was added to the click handler, but it can
really go into activate_section().  This way the code
also runs when we first launch settings.
This commit is contained in:
Steve Howell
2018-12-02 20:10:32 +00:00
committed by Tim Abbott
parent 473f2650fd
commit c4d3578de3
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
static/js/settings_panel_menu.js
View File

@@ -79,6 +79,12 @@ exports.make_menu = function (opts) {
load_section(section);
self.get_panel().addClass('show');
var $settings_overlay_container = $("#settings_overlay_container");
$settings_overlay_container.find(".right").addClass("show");
$settings_overlay_container.find(".settings-header.mobile").addClass("slide-left");
settings.set_settings_header(section);
};
self.get_panel = function () {
@@ -93,11 +99,8 @@ exports.make_menu = function (opts) {
self.activate_section(section);
var $settings_overlay_container = $("#settings_overlay_container");
$settings_overlay_container.find(".right").addClass("show");
$settings_overlay_container.find(".settings-header.mobile").addClass("slide-left");
settings.set_settings_header(section);
// You generally want to add logic to activate_section,
// not to this click handler.
e.stopPropagation();
});