diff --git a/zerver/lib/error_notify.py b/zerver/lib/error_notify.py index cf60084c3f..c647c462d7 100644 --- a/zerver/lib/error_notify.py +++ b/zerver/lib/error_notify.py @@ -4,13 +4,9 @@ from typing import Any, Dict from django.conf import settings from django.core.mail import mail_admins -from django.http import HttpResponse -from django.utils.translation import gettext as _ from zerver.filters import clean_data_from_query_parameters from zerver.lib.actions import internal_send_stream_message -from zerver.lib.exceptions import JsonableError -from zerver.lib.response import json_success from zerver.models import get_realm, get_stream, get_system_bot @@ -194,11 +190,8 @@ Error generated by {user_info} mail_admins(format_email_subject(email_subject), message, fail_silently=True) -def do_report_error(type: str, report: Dict[str, Any]) -> HttpResponse: +def do_report_error(type: str, report: Dict[str, Any]) -> None: if type == "browser": notify_browser_error(report) elif type == "server": notify_server_error(report) - else: - raise JsonableError(_("Invalid type parameter")) - return json_success() diff --git a/zerver/worker/queue_processors.py b/zerver/worker/queue_processors.py index 14881acf71..010287ce76 100644 --- a/zerver/worker/queue_processors.py +++ b/zerver/worker/queue_processors.py @@ -797,6 +797,9 @@ class PushNotificationsWorker(QueueProcessingWorker): @assign_queue("error_reports") class ErrorReporter(QueueProcessingWorker): def consume(self, event: Mapping[str, Any]) -> None: + error_types = ["browser", "server"] + assert event["type"] in error_types + logging.info( "Processing traceback with type %s for %s", event["type"], event.get("user_email") )