paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

typing: Avoid redefinition of variables with different types.

Browse Source 
Signed-off-by: Zixuan James Li <p359101898@gmail.com>
This commit is contained in:
Zixuan James Li
2022-06-14 22:24:28 -04:00
committed by Tim Abbott
parent 5fd278bf09
commit c567e44408
5 changed files with 26 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
zerver/lib/test_classes.py
View File

@@ -1517,25 +1517,25 @@ Output:
"""
dct = {}
for row in RealmEmoji.objects.all():
dct[row.id] = row
for realm_emoji in RealmEmoji.objects.all():
dct[realm_emoji.id] = realm_emoji
if not dct:
raise AssertionError("test needs RealmEmoji rows")
count = 0
for row in Reaction.objects.filter(reaction_type=Reaction.REALM_EMOJI):
realm_emoji_id = int(row.emoji_code)
for reaction in Reaction.objects.filter(reaction_type=Reaction.REALM_EMOJI):
realm_emoji_id = int(reaction.emoji_code)
assert realm_emoji_id in dct
self.assertEqual(dct[realm_emoji_id].name, row.emoji_name)
self.assertEqual(dct[realm_emoji_id].realm_id, row.user_profile.realm_id)
self.assertEqual(dct[realm_emoji_id].name, reaction.emoji_name)
self.assertEqual(dct[realm_emoji_id].realm_id, reaction.user_profile.realm_id)
count += 1
for row in UserStatus.objects.filter(reaction_type=UserStatus.REALM_EMOJI):
realm_emoji_id = int(row.emoji_code)
for user_status in UserStatus.objects.filter(reaction_type=UserStatus.REALM_EMOJI):
realm_emoji_id = int(user_status.emoji_code)
assert realm_emoji_id in dct
self.assertEqual(dct[realm_emoji_id].name, row.emoji_name)
self.assertEqual(dct[realm_emoji_id].realm_id, row.user_profile.realm_id)
self.assertEqual(dct[realm_emoji_id].name, user_status.emoji_name)
self.assertEqual(dct[realm_emoji_id].realm_id, user_status.user_profile.realm_id)
count += 1
if count == 0: