paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-08 07:52:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

zerver/lib/str_utils.py: Replace ValueError by TypeError.

Browse Source 
When a parameter of a wrong type is passed to a `force_*` method
in str_utils.py, raise a TypeError.
This commit is contained in:
Eklavya Sharma
2016-07-21 22:34:24 +05:30
parent dce48d58b6
commit c59740385d
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
zerver/lib/str_utils.py
View File

@@ -45,7 +45,7 @@ def force_text(s, encoding='utf-8'):
elif isinstance(s, binary_type): elif isinstance(s, binary_type):
return s.decode(encoding) return s.decode(encoding)
else: else:
raise ValueError("force_text expects a string type") raise TypeError("force_text expects a string type")
def force_bytes(s, encoding='utf-8'): def force_bytes(s, encoding='utf-8'):
# type: (Union[text_type, binary_type], str) -> binary_type # type: (Union[text_type, binary_type], str) -> binary_type
@@ -55,7 +55,7 @@ def force_bytes(s, encoding='utf-8'):
elif isinstance(s, text_type): elif isinstance(s, text_type):
return s.encode(encoding) return s.encode(encoding)
else: else:
raise ValueError("force_bytes expects a string type") raise TypeError("force_bytes expects a string type")
def force_str(s, encoding='utf-8'): def force_str(s, encoding='utf-8'):
# type: (Union[text_type, binary_type], str) -> str # type: (Union[text_type, binary_type], str) -> str
@@ -67,7 +67,7 @@ def force_str(s, encoding='utf-8'):
elif isinstance(s, binary_type): elif isinstance(s, binary_type):
return s.decode(encoding) return s.decode(encoding)
else: else:
raise ValueError("force_str expects a string type") raise TypeError("force_str expects a string type")
def dict_with_str_keys(dct, encoding='utf-8'): def dict_with_str_keys(dct, encoding='utf-8'):
# type: (Mapping[NonBinaryStr, Any], str) -> Dict[str, Any] # type: (Mapping[NonBinaryStr, Any], str) -> Dict[str, Any]