paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

dialog_widget: Simplify rendering logic.

Browse Source 
This makes the templates a lot more readable.
This commit is contained in:
Tim Abbott
2021-07-14 13:21:06 -07:00
parent e0135e278d
commit c5b455d5c2
2 changed files with 16 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
static/js/dialog_widget.js
View File

@@ -85,32 +85,26 @@ export function launch(conf) {
}
}
const html = render_dialog_widget({
fade: conf.fade,
danger_submit_button: conf.danger_submit_button,
});
const dialog = $(html);
conf.parent.append(dialog);
// Close any existing modals--on settings screens you can
// have multiple buttons that need confirmation.
if (overlays.is_modal_open()) {
overlays.close_modal("#dialog_widget_modal");
}
dialog.find(".dialog_heading").html(
render_dialog_heading({
heading_text: conf.html_heading,
link: conf.help_link,
}),
);
dialog.find(".dialog_body").append(conf.html_body);
const submit_button_span = dialog.find(".dialog_submit_button span");
const html_submit_button = conf.html_submit_button || $t_html({defaultMessage: "Save changes"});
submit_button_span.html(html_submit_button);
const html_dialog_heading = render_dialog_heading({
heading_text: conf.html_heading,
link: conf.help_link,
});
const html = render_dialog_widget({
fade: conf.fade,
html_submit_button,
html_dialog_heading,
html_body: conf.html_body,
danger_submit_button: conf.danger_submit_button,
});
const dialog = $(html);
conf.parent.append(dialog);
if (conf.post_render !== undefined) {
conf.post_render();