paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 10:26:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list: Rename variable for caller clarity.

Browse Source
This commit is contained in:
Aman Agrawal
2024-12-19 09:14:19 +05:30
committed by Tim Abbott
parent fd9a73bde3
commit c5feccaa34
4 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/src/message_fetch.ts
View File

@@ -153,7 +153,7 @@ function process_result(data: MessageFetchResponse, opts: MessageFetchOptions):
// messages not tracked in unread.ts during this fetching process. // messages not tracked in unread.ts during this fetching process.
message_util.do_unread_count_updates(messages, true); message_util.do_unread_count_updates(messages, true);
const ignore_found_newest = true; const is_contiguous_history = true;
if (messages.length > 0) { if (messages.length > 0) {
if (opts.msg_list) { if (opts.msg_list) {
if (opts.validate_filter_topic_post_fetch) { if (opts.validate_filter_topic_post_fetch) {
@@ -161,9 +161,9 @@ function process_result(data: MessageFetchResponse, opts: MessageFetchOptions):
} }
// Since this adds messages to the MessageList and renders MessageListView, // Since this adds messages to the MessageList and renders MessageListView,
// we don't need to call it if msg_list was not defined by the caller. // we don't need to call it if msg_list was not defined by the caller.
opts.msg_list.add_messages(messages, {}, ignore_found_newest); opts.msg_list.add_messages(messages, {}, is_contiguous_history);
} else { } else {
opts.msg_list_data.add_messages(messages, ignore_found_newest); opts.msg_list_data.add_messages(messages, is_contiguous_history);
} }
} }

4
web/src/message_list.ts
View File

@@ -193,11 +193,11 @@ export class MessageList {
add_messages( add_messages(
messages: Message[], messages: Message[],
append_to_view_opts: {messages_are_new?: boolean} = {}, append_to_view_opts: {messages_are_new?: boolean} = {},
ignore_found_newest = false, is_contiguous_history = false,
): RenderInfo | undefined { ): RenderInfo | undefined {
// This adds all messages to our data, but only returns // This adds all messages to our data, but only returns
// the currently viewable ones. // the currently viewable ones.
const info = this.data.add_messages(messages, ignore_found_newest); const info = this.data.add_messages(messages, is_contiguous_history);
const top_messages = info.top_messages; const top_messages = info.top_messages;
const bottom_messages = info.bottom_messages; const bottom_messages = info.bottom_messages;

4
web/src/message_list_data.ts
View File

@@ -297,7 +297,7 @@ export class MessageListData {
add_messages( add_messages(
messages: Message[], messages: Message[],
ignore_found_newest = false, is_contiguous_history = false,
): { ): {
top_messages: Message[]; top_messages: Message[];
bottom_messages: Message[]; bottom_messages: Message[];
@@ -335,7 +335,7 @@ export class MessageListData {
top_messages = this.prepend(top_messages); top_messages = this.prepend(top_messages);
} }
if (!ignore_found_newest && !this.fetch_status.has_found_newest()) { if (!is_contiguous_history && !this.fetch_status.has_found_newest()) {
// Don't add messages at the bottom if we haven't found // Don't add messages at the bottom if we haven't found
// the latest message to avoid non-contiguous message history. // the latest message to avoid non-contiguous message history.
this.fetch_status.update_expected_max_message_id(bottom_messages); this.fetch_status.update_expected_max_message_id(bottom_messages);

4
web/src/message_view.ts
View File

@@ -912,8 +912,8 @@ function load_local_messages(msg_data: MessageListData, superset_data: MessageLi
// one message the user will expect to see in the new narrow. // one message the user will expect to see in the new narrow.
const in_msgs = superset_data.all_messages(); const in_msgs = superset_data.all_messages();
const ignore_found_newest = true; const is_contiguous_history = true;
msg_data.add_messages(in_msgs, ignore_found_newest); msg_data.add_messages(in_msgs, is_contiguous_history);
return !msg_data.visibly_empty(); return !msg_data.visibly_empty();
} }