refactor: Extract narrow_banner module.

This is a mostly verbatim extraction.

I re-phrased one line of code to work around a lint
false alarm. (Look for `preamble` in the diff.)

There are about 8 lines missing coverage here, so
the new module might be a good candidate to get
100% line coverage on.

Before this change, you would need to remove 74
edges from our dependency graph to make it
acyclic. Now it's 72.
This commit is contained in:
Steve Howell
2021-03-26 14:21:47 +00:00
committed by Tim Abbott
parent e72f208fde
commit c67f82b073
8 changed files with 220 additions and 220 deletions

View File

@@ -132,12 +132,6 @@ js_rules = RuleList(
{
"pattern": r"i18n\.t\(.+\).*\+",
"description": "Do not concatenate i18n strings",
"exclude_line": {
(
"static/js/narrow.js",
'i18n.t("Some common words were excluded from your search.") +',
),
},
},
{"pattern": r"\+.*i18n\.t\(.+\)", "description": "Do not concatenate i18n strings"},
{