paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

bulk_access_messages: Support passing in a stream for all messages.

Browse Source 
This lets us avoid fetching the Stream in a loop.
This commit is contained in:
Tim Abbott
2021-05-12 14:21:39 -07:00
committed by Tim Abbott
parent 4a8dcf14ef
commit c6e1702335
2 changed files with 26 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/lib/message.py
View File

@@ -726,7 +726,9 @@ def has_message_access(
).exists()
def bulk_access_messages(user_profile: UserProfile, messages: Sequence[Message]) -> List[Message]:
def bulk_access_messages(
user_profile: UserProfile, messages: Sequence[Message], *, stream: Optional[Stream] = None
) -> List[Message]:
filtered_messages = []
user_message_set = set(
@@ -737,7 +739,9 @@ def bulk_access_messages(user_profile: UserProfile, messages: Sequence[Message])
for message in messages:
has_user_message = message.id in user_message_set
if has_message_access(user_profile, message, has_user_message=has_user_message):
if has_message_access(
user_profile, message, has_user_message=has_user_message, stream=stream
):
filtered_messages.append(message)
return filtered_messages