paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-23 04:52:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_list: Move show_message_as_read to view layer.

Browse Source
This commit is contained in:
Tim Abbott
2023-04-21 09:02:38 -07:00
parent c99c71a9a5
commit c8f1325281
4 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/message_list.js
View File

@@ -394,16 +394,6 @@ export class MessageList {
$recipient_row.find(".always_visible_topic_edit").show();
}
show_message_as_read(message, options) {
const $row = this.get_row(message.id);
if (options.from === "pointer" || options.from === "server") {
$row.find(".unread_marker").addClass("fast_fade");
} else {
$row.find(".unread_marker").addClass("slow_fade");
}
$row.removeClass("unread");
}
reselect_selected_id() {
const selected_id = this.data.selected_id();

10
web/src/message_list_view.js
View File

@@ -1577,4 +1577,14 @@ export class MessageListView {
stream_color.update_stream_recipient_color($stream_header);
}
}
show_message_as_read(message, options) {
const $row = this.get_row(message.id);
if (options.from === "pointer" || options.from === "server") {
$row.find(".unread_marker").addClass("fast_fade");
} else {
$row.find(".unread_marker").addClass("slow_fade");
}
$row.removeClass("unread");
}
}

2
web/src/unread_ops.js
View File

@@ -150,7 +150,7 @@ export function mark_all_as_read(args = {}) {
function process_newly_read_message(message, options) {
for (const msg_list of message_lists.all_rendered_message_lists()) {
msg_list.show_message_as_read(message, options);
msg_list.view.show_message_as_read(message, options);
}
notifications.close_notification(message);
recent_topics_ui.update_topic_unread_count(message);

8
web/tests/example7.test.js
View File

@@ -55,8 +55,8 @@ const message_viewport = mock_esm("../src/message_viewport");
const notifications = mock_esm("../src/notifications");
const unread_ui = mock_esm("../src/unread_ui");
message_lists.current = {};
message_lists.home = {};
message_lists.current = {view: {}};
message_lists.home = {view: {}};
message_lists.all_rendered_message_lists = () => [message_lists.home, message_lists.current];
const message_store = zrequire("message_store");
@@ -107,8 +107,8 @@ run_test("unread_ops", ({override}) => {
override(message_lists.current, "all_messages", () => test_messages);
// Ignore these interactions for now:
override(message_lists.current, "show_message_as_read", () => {});
override(message_lists.home, "show_message_as_read", () => {});
override(message_lists.current.view, "show_message_as_read", () => {});
override(message_lists.home.view, "show_message_as_read", () => {});
override(notifications, "close_notification", () => {});
override(unread_ui, "update_unread_counts", () => {});
override(unread_ui, "notify_messages_remain_unread", () => {});