mirror of
https://github.com/zulip/zulip.git
synced 2025-10-25 00:53:56 +00:00
test-all: Fix shellcheck warnings.
In tools/test-all line 7:
TEMP=`getopt -o f --long force -- "$@"`
^-- SC2006: Use $(..) instead of legacy `..`.
In tools/test-all line 24:
echo "Running $@"
^-- SC2145: Argument mixes string and array. Use * or separate argument.
In tools/test-all line 26:
printf "\n\e[31;1mFAILED\e[0m $@\n"
^-- SC2059: Don't use variables in the printf format string. Use printf "..%s.." "$foo".
^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".
^-- SC1117: Backslash is literal in "\e". Prefer explicit escaping: "\\e".
^-- SC1117: Backslash is literal in "\e". Prefer explicit escaping: "\\e".
^-- SC2145: Argument mixes string and array. Use * or separate argument.
^-- SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
This commit is contained in:
committed by
Tim Abbott
parent
e9656564c2
commit
c93f53b463
@@ -4,7 +4,7 @@ set -e
|
|||||||
cd "$(dirname "$0")"/..
|
cd "$(dirname "$0")"/..
|
||||||
|
|
||||||
# read the options
|
# read the options
|
||||||
TEMP=`getopt -o f --long force -- "$@"`
|
TEMP=$(getopt -o f --long force -- "$@")
|
||||||
eval set -- "$TEMP"
|
eval set -- "$TEMP"
|
||||||
|
|
||||||
# extract options.
|
# extract options.
|
||||||
@@ -21,9 +21,13 @@ done
|
|||||||
|
|
||||||
function run {
|
function run {
|
||||||
echo '----'
|
echo '----'
|
||||||
echo "Running $@"
|
printf 'Running'
|
||||||
|
printf ' %q' "$@"
|
||||||
|
printf '\n'
|
||||||
if ! "$@"; then
|
if ! "$@"; then
|
||||||
printf "\n\e[31;1mFAILED\e[0m $@\n"
|
printf '\n\e[31;1mFAILED\e[0m'
|
||||||
|
printf ' %q' "$@"
|
||||||
|
printf '\n'
|
||||||
exit 1
|
exit 1
|
||||||
else
|
else
|
||||||
echo
|
echo
|
||||||
|
|||||||
Reference in New Issue
Block a user