paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

hotspots.js: Inline map_hotspots_to_DOM.

Browse Source 
The function is confusing and added unnecessary complexity, given that it is
only called in one place, and is not a function that should be exposed to
other modules.
This commit is contained in:
Rishi Gupta
2017-08-30 19:46:10 -07:00
committed by Tim Abbott
parent 546384ce30
commit c985791773
2 changed files with 3 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
frontend_tests/node_tests/hotspots.js
View File

@@ -1,38 +0,0 @@
const hotspots = require('js/hotspots');
const test_hotspots = [
{
delay: 5,
description: 'Click anywhere on a message to reply.',
name: 'click_to_reply',
title: 'Respond to a message',
},
];
const TEST_HOTSPOT_LOCATIONS = {
click_to_reply: {
element: '.selected_message .messagebox-content',
icon: {
top: -71,
left: 284,
},
popover: {
top: -213,
left: -176,
arrow: {
placement: 'bottom',
top: -5,
left: -5,
},
},
},
};
(function test_map_hotspot_to_DOM() {
const test_hotspot = test_hotspots[0];
assert.equal(test_hotspot.location, undefined);
hotspots.map_hotspots_to_DOM(test_hotspots, TEST_HOTSPOT_LOCATIONS);
assert.deepEqual(test_hotspot.location, TEST_HOTSPOT_LOCATIONS[test_hotspot.name]);
}());

11
static/js/hotspots.js
View File

@@ -32,13 +32,6 @@ var HOTSPOT_LOCATIONS = {
// popover illustration url(s) // popover illustration url(s)
var WHALE = '/static/images/hotspots/whale.svg'; var WHALE = '/static/images/hotspots/whale.svg';
exports.map_hotspots_to_DOM = function (hotspots, locations) {
hotspots.forEach(function (hotspot) {
hotspot.location = locations[hotspot.name];
});
};
exports.post_hotspot_as_read = function (hotspot_name) { exports.post_hotspot_as_read = function (hotspot_name) {
channel.post({ channel.post({
url: '/json/users/me/hotspots', url: '/json/users/me/hotspots',
@@ -208,7 +201,9 @@ exports.is_open = function () {
}; };
exports.load_new = function (new_hotspots) { exports.load_new = function (new_hotspots) {
exports.map_hotspots_to_DOM(new_hotspots, HOTSPOT_LOCATIONS); new_hotspots.forEach(function (hotspot) {
hotspot.location = HOTSPOT_LOCATIONS[hotspot.name];
});
new_hotspots.forEach(insert_hotspot_into_DOM); new_hotspots.forEach(insert_hotspot_into_DOM);
}; };