paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 04:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Distinguish get_message_type() from composing().

Browse Source 
We now only call compose_state.composing() in a boolean context,
where we simply care whether or not the compose box is open.  The
function now also returns true/false.

Callers who need to know the actual message type (e.g. "stream" or
"private") now call compose_state.get_message_type().
This commit is contained in:
Steve Howell
2017-04-24 11:35:26 -07:00
committed by Tim Abbott
parent 2adf641b72
commit c999bdf823
8 changed files with 18 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/typing.js
View File

@@ -39,7 +39,7 @@ function is_valid_conversation(recipient) {
return false;
}
if (compose_state.composing() !== 'private') {
if (compose_state.get_message_type() !== 'private') {
// We only use typing indicators in PMs for now.
// There was originally some support for having
// typing indicators related to stream conversations,