From ca1dcf222fef04f6e88c7388a100cbb5ce26a827 Mon Sep 17 00:00:00 2001 From: Waseem Daher Date: Tue, 16 Oct 2012 11:30:07 -0400 Subject: [PATCH] Don't allow the top of the pointer to be past the 2/3 mark. Given that we now look at the top of the pointer rather than the bottom for this check, our previous 4/5 number was far too permissive (and led to your selected message often getting covered up by the compose window). Anecdotally, this feels a bit better to me. (imported from commit 39ca7924db56272f7e623708ce0125b2a7012656) --- zephyr/static/js/zephyr.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zephyr/static/js/zephyr.js b/zephyr/static/js/zephyr.js index b53bbcd7c0..09021557f0 100644 --- a/zephyr/static/js/zephyr.js +++ b/zephyr/static/js/zephyr.js @@ -87,8 +87,8 @@ function above_view_threshold(message, useTop) { function below_view_threshold(message) { // Barnowl-style thresholds: the top of the pointer is never below - // the 4/5-mark. - return message.offset().top > viewport.scrollTop() + viewport.height() * 4 / 5; + // the 2/3-mark. + return message.offset().top > viewport.scrollTop() + viewport.height() * 2 / 3; } function recenter_view(message) {