paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

condense: Remove _message_content_height_cache.

Browse Source 
Since `scrollHeight` is very quick, we don't need
the cache anymore, and the code is easier to reason
about without it.

Profiling checks described on CZO here:
https://chat.zulip.org/#narrow/stream/6-frontend/topic/resize.20undo.20redo.20condense/near/1581520
This commit is contained in:
evykassirer
2023-05-31 23:07:47 -07:00
committed by Tim Abbott
parent 43b18eabf1
commit ca6e93ac7d
4 changed files with 5 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/tests/message_events.test.js
View File

@@ -7,7 +7,6 @@ const {run_test} = require("./lib/test");
const $ = require("./lib/zjquery");
const {page_params} = require("./lib/zpage_params");
const condense = mock_esm("../src/condense");
const message_edit = mock_esm("../src/message_edit");
const message_lists = mock_esm("../src/message_lists");
const notifications = mock_esm("../src/notifications");
@@ -99,7 +98,6 @@ run_test("update_messages", () => {
message_lists.home = message_lists.current;
const side_effects = [
[condense, "un_cache_message_content_height"],
[message_edit, "end_message_edit"],
[notifications, "received_messages"],
[unread_ui, "update_unread_counts"],