dependencies: Upgrade JavaScript dependencies.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

help-beta/package.json

@@ -11,7 +11,7 @@
   },
   "dependencies": {
     "@astrojs/check": "^0.9.3",
-    "@astrojs/starlight": "^0.28.2",
+    "@astrojs/starlight": "^0.29.2",
     "astro": "^4.10.2",
     "sharp": "^0.33.5",
     "typescript": "^5.4.5"

package.json

@@ -1,6 +1,6 @@
 {
   "private": true,
-  "packageManager": "pnpm@9.12.3+sha512.cce0f9de9c5a7c95bef944169cc5dfe8741abfb145078c0d508b868056848a87c81e626246cb60967cbd7fd29a6c062ef73ff840d96b3c86c40ac92cf4a813ee",
+  "packageManager": "pnpm@9.14.2+sha512.6e2baf77d06b9362294152c851c4f278ede37ab1eba3a55fda317a4a17b209f4dbb973fb250a77abc463a341fcb1f17f17cfa24091c4eb319cda0d9b84278387",
   "type": "module",
   "dependencies": {
     "@babel/core": "^7.5.5",
@@ -8,7 +8,7 @@
     "@babel/preset-typescript": "^7.15.0",
     "@babel/register": "^7.6.2",
     "@fontsource-variable/open-sans": "^5.0.9",
-    "@formatjs/intl": "^2.0.0",
+    "@formatjs/intl": "^3.0.1",
     "@gfx/zopfli": "^1.0.15",
     "@giphy/js-components": "^5.13.0",
     "@giphy/js-fetch-api": "^5.6.0",
@@ -86,7 +86,7 @@
     "tippy.js": "^6.3.7",
     "turndown": "^7.0.0",
     "url-loader": "^4.1.1",
-    "url-template": "^2.0.8",
+    "url-template": "^3.1.1",
     "webfonts-loader": "^8.0.0",
     "webpack": "^5.61.0",
     "webpack-bundle-tracker": "^3.0.1",
@@ -95,10 +95,9 @@
     "zod": "^3.21.4"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.11.3",
     "@babel/plugin-transform-modules-commonjs": "^7.19.6",
-    "@eslint/eslintrc": "^2.1.4",
+    "@eslint/eslintrc": "^3.2.0",
-    "@eslint/js": "^8.57.1",
+    "@eslint/js": "^9.15.0",
     "@formatjs/cli": "^6.0.0",
     "@giphy/js-types": "^5.1.0",
     "@types/autosize": "^4.0.1",
@@ -128,7 +127,7 @@
     "@typescript-eslint/eslint-plugin": "^8.2.0",
     "@typescript-eslint/parser": "^8.2.0",
     "babel-plugin-istanbul": "^7.0.0",
-    "callsites": "^3.1.0",
+    "callsites": "^4.2.0",
     "cldr-annotations-derived-modern": "^45.0.0",
     "cldr-annotations-modern": "^45.0.0",
     "confusing-browser-globals": "^1.0.11",
@@ -137,18 +136,18 @@
     "difflib": "^0.2.4",
     "enhanced-resolve": "^5.8.2",
     "es-check": "^7.0.0",
-    "eslint": "^8.0.1",
+    "eslint": "^9.15.0",
     "eslint-config-prettier": "^9.0.0",
     "eslint-import-resolver-webpack": "^0.13.4",
     "eslint-plugin-formatjs": "^5.0.0",
     "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-no-jquery": "^3.0.2",
     "eslint-plugin-unicorn": "^56.0.0",
-    "globals": "^13.24.0",
+    "globals": "^15.12.0",
     "jsdom": "^25.0.0",
     "mockdate": "^3.0.2",
     "nyc": "^17.0.0",
-    "openapi-examples-validator": "^5.0.0",
+    "openapi-examples-validator": "^6.0.1",
     "preact": "^10.24.3",
     "prettier": "^3.0.0",
     "puppeteer": "^23.5.0",

tools/test-js-with-node

@@ -173,7 +173,6 @@ EXEMPT_FILES = make_set(
         "web/src/page_params.ts",
         "web/src/personal_menu_popover.ts",
         "web/src/playground_links_popover.ts",
-        "web/src/plotly.js.d.ts",
         "web/src/pm_list.ts",
         "web/src/pm_list_dom.ts",
         "web/src/poll_modal.ts",
@@ -268,7 +267,6 @@ EXEMPT_FILES = make_set(
         "web/src/unread_ui.ts",
         "web/src/upload.ts",
         "web/src/upload_widget.ts",
-        "web/src/url-template.d.ts",
         "web/src/user_card_popover.js",
         "web/src/user_deactivation_ui.ts",
         "web/src/user_events.js",

version.py

@@ -49,4 +49,4 @@ API_FEATURE_LEVEL = 322  # Last bumped for adding users to groups using invitati
 #   historical commits sharing the same major version, in which case a
 #   minor version bump suffices.
 
-PROVISION_VERSION = (303, 1)  # bumped 2024-11-26 for flat ESLint config
+PROVISION_VERSION = (304, 0)  # bumped 2024-11-26 to upgrade JavaScript dependencies

web/src/linkifiers.ts

@@ -1,4 +1,4 @@
-import url_template_lib from "url-template";
+import * as url_template_lib from "url-template";
 
 import * as blueslip from "./blueslip.ts";
 
@@ -83,7 +83,7 @@ function python_to_js_linkifier(
             throw error;
         }
     }
-    const url_template = url_template_lib.parse(url);
+    const url_template = url_template_lib.parseTemplate(url);
     return [final_regex, url_template, group_number_to_name];
 }
 

web/src/playground_links_popover.ts

@@ -1,6 +1,6 @@
 import $ from "jquery";
 import type * as tippy from "tippy.js";
-import url_template_lib from "url-template";
+import * as url_template_lib from "url-template";
 
 import render_playground_links_popover from "../templates/popovers/playground_links_popover.hbs";
 
@@ -117,13 +117,15 @@ function register_click_handlers(): void {
             // a popover is shown.
             const extracted_code = $codehilite_div.find("code").text();
             if (playground_info.length === 1 && playground_info[0] !== undefined) {
-                const url_template = url_template_lib.parse(playground_info[0].url_template);
+                const url_template = url_template_lib.parseTemplate(
+                    playground_info[0].url_template,
+                );
                 const playground_url = url_template.expand({code: extracted_code});
                 window.open(playground_url, "_blank", "noopener,noreferrer");
             } else {
                 const playground_store = new Map<number, RealmPlaygroundWithURL>();
                 for (const playground of playground_info) {
-                    const url_template = url_template_lib.parse(playground.url_template);
+                    const url_template = url_template_lib.parseTemplate(playground.url_template);
                     const playground_url = url_template.expand({code: extracted_code});
                     playground_store.set(playground.id, {...playground, playground_url});
                 }

web/src/plotly.js.d.ts

@@ -1,19 +0,0 @@
-// An internal type extracted from @types/plotly.js
-// pie and bar are both trace modules from the traces subdirectory
-type TraceModule = {
-    [key: string]: unknown;
-    moduleType: "trace";
-    name: string;
-    categories: string[];
-    meta: Record<string, unknown>;
-};
-
-declare module "plotly.js/lib/pie" {
-    const PlotlyPie: TraceModule;
-    export = PlotlyPie;
-}
-
-declare module "plotly.js/lib/bar" {
-    const PlotlyBar: TraceModule;
-    export = PlotlyBar;
-}

web/src/types/plotly.js/lib/bar.d.ts

@@ -0,0 +1,4 @@
+export const moduleType: "trace";
+export const name: "bar";
+export const categories: string[];
+export const meta: {description: string};

web/src/url-template.d.ts

@@ -1,19 +0,0 @@
-// We need to use an older version of url-template because our test suite setup does not
-// support testing with ESM-only modules. Unfortunately, the older version also happens to
-// not have type definitions, so we maintain our own copy of it. This is adapted from:
-// https://github.com/bramstein/url-template/blob/a8e204a92de3168a56ef2e528ae4d841287636fd/lib/url-template.d.ts
-
-declare module "url-template" {
-    export type PrimitiveValue = string | number | boolean | null;
-
-    export type Template = {
-        expand: (
-            context: Record<
-                string,
-                PrimitiveValue | PrimitiveValue[] | Record<string, PrimitiveValue>
-            >,
-        ) => string;
-    };
-
-    export function parse(template: string): Template;
-}

web/styles/app_variables.css

@@ -293,7 +293,8 @@
         (
                 var(--line-height-sidebar-row-prominent) -
                     var(--line-height-sidebar-topic-inner)
-            ) / 2
+            ) /
+            2
     );
 
     /* Right sidebar */
@@ -342,8 +343,10 @@
                             var(--base-maximum-block-height-em),
                             var(--length-line-fitted-block)
                         )
-                    ) - var(--length-line-oversize-block)
+                    ) -
-            ) / 2
+                    var(--length-line-oversize-block)
+            ) /
+            2
     );
 
     /* Legacy values */

web/styles/inbox.css

@@ -153,8 +153,8 @@
             margin-bottom: var(--max-unmaximized-compose-height);
             /* margin(5) + search left padding(30) + search right padding (28) + border(2px) = 65px */
             max-width: calc(
-                var(--width-inbox-search) + var(--width-inbox-filters-dropdown) +
+                var(--width-inbox-search) +
-                    65px
+                    var(--width-inbox-filters-dropdown) + 65px
             );
 
             .inbox-focus-border {

web/styles/left_sidebar.css

@@ -958,10 +958,8 @@ li.top_left_scheduled_messages {
 #views-label-container {
     margin-right: var(--left-sidebar-right-margin);
     grid-template-columns:
-        0 var(--left-sidebar-header-icon-toggle-width) 0 minmax(0, 0.5fr) 0 minmax(
+        0 var(--left-sidebar-header-icon-toggle-width) 0 minmax(0, 0.5fr)
-            0,
+        0 minmax(0, 1fr)
-            1fr
-        )
         var(--left-sidebar-vdots-width) 0;
     grid-template-rows: 28px;
     cursor: pointer;
@@ -1461,10 +1459,8 @@ li.topic-list-item {
         var(--left-sidebar-toggle-width-offset) [action-heading-start] var(
             --left-sidebar-icon-column-width
         )
-        var(--left-sidebar-icon-content-gap) minmax(0, 1fr) [action-heading-end] 0 minmax(
+        var(--left-sidebar-icon-content-gap) minmax(0, 1fr)
-            0,
+        [action-heading-end] 0 minmax(0, max-content)
-            max-content
-        )
         var(--left-sidebar-vdots-width) 0;
     grid-template-rows: [action-heading-start] auto [action-heading-end];
 

web/styles/message_header.css

@@ -161,7 +161,8 @@
         }
 
         &.sticky_header {
-            box-shadow: var(--unread-marker-left) -1px 0 0 var(--color-background);
+            box-shadow: var(--unread-marker-left) -1px 0 0
+                var(--color-background);
 
             .recipient_row_date {
                 display: block;

web/styles/message_row.css

@@ -341,7 +341,10 @@
                of the avatar. We also need to account for the
                padding atop .message_content. */
             margin-top: calc(
-                (var(--message-box-markdown-aligned-vertical-space) * 0.5 * -1) -
+                (
+                        var(--message-box-markdown-aligned-vertical-space) *
+                            0.5 * -1
+                    ) -
                     var(--message-box-markdown-aligned-vertical-space)
             );
             grid-area: message;

web/styles/right_sidebar.css

@@ -292,10 +292,9 @@ $user_status_emoji_width: 24px;
 }
 
 .user_sidebar_entry.with_avatar {
-    grid-template: "row-content" var(--line-height-sidebar-row-with-avatars) "row-content" auto / minmax(
+    grid-template:
-            0,
+        "row-content" var(--line-height-sidebar-row-with-avatars)
-            1fr
+        "row-content" auto / minmax(0, 1fr);
-        );
 
     .selectable_sidebar_block {
         margin: 4px;
@@ -554,10 +553,9 @@ $user_status_emoji_width: 24px;
     padding-left: 0;
 
     .invite-user-link {
-        grid-template-columns: var(--right-sidebar-header-icon-toggle-width) minmax(
+        grid-template-columns:
-                0,
+            var(--right-sidebar-header-icon-toggle-width)
-                1fr
+            minmax(0, 1fr);
-            );
 
         .zulip-icon-user-plus {
             justify-self: center;

web/tests/lib/namespace.cjs

@@ -4,7 +4,7 @@ const assert = require("node:assert/strict");
 const Module = require("node:module");
 const path = require("node:path");
 
-const callsites = require("callsites");
+const {default: callsites} = require("callsites");
 
 const $ = require("./zjquery.cjs");
 

web/tests/markdown_parse.test.cjs

@@ -117,7 +117,7 @@ function get_realm_emoji_url(emoji_name) {
 const regex = /#foo(\d+)(?!\w)/g;
 const linkifier_map = new Map();
 linkifier_map.set(regex, {
-    url_template: url_template_lib.parse("http://foo.com/{id}"),
+    url_template: url_template_lib.parseTemplate("http://foo.com/{id}"),
     group_number_to_name: {1: "id"},
 });