left_sidebar: Rename show_all_private_messages to use direct.

Rename `show_all_private_messages` to `show-all-direct-messages`.
We've also hyphenated the attribute during the rename.
Part of the private_message to direct_message rename project.

web/e2e-tests/message-basics.test.ts

@@ -319,7 +319,7 @@ async function test_narrow_by_clicking_the_left_sidebar(page: Page): Promise<voi
     await page.click("#left-sidebar-navigation-list .top_left_all_messages a");
     await expect_home(page);
 
-    const all_private_messages_icon = "#show_all_private_messages";
+    const all_private_messages_icon = "#show-all-direct-messages";
     await page.waitForSelector(all_private_messages_icon, {visible: true});
     await page.click(all_private_messages_icon);
     await expect_all_direct_messages(page);

web/e2e-tests/navigation.test.ts

@@ -56,7 +56,7 @@ async function navigate_to_subscriptions(page: Page): Promise<void> {
 async function navigate_to_private_messages(page: Page): Promise<void> {
     console.log("Navigate to direct messages");
 
-    const all_private_messages_icon = "#show_all_private_messages";
+    const all_private_messages_icon = "#show-all-direct-messages";
     await page.waitForSelector(all_private_messages_icon, {visible: true});
     await page.click(all_private_messages_icon);
 

web/src/click_handlers.js

@@ -781,7 +781,7 @@ export function initialize() {
         "click",
         ".direct-messages-container.zoom-out #direct-messages-section-header",
         (e) => {
-            if ($(e.target).closest("#show_all_private_messages").length === 1) {
+            if ($(e.target).closest("#show-all-direct-messages").length === 1) {
                 // Let the browser handle the "direct message feed" widget.
                 return;
             }

web/src/tippyjs.ts

@@ -139,7 +139,7 @@ export function initialize(): void {
     // thus hovering it is a way to find out what it does, give
     // it the faster LONG_HOVER_DELAY.
     tippy.delegate("body", {
-        target: "#show_all_private_messages",
+        target: "#show-all-direct-messages",
         placement: "right",
         delay: LONG_HOVER_DELAY,
         appendTo: () => document.body,

web/styles/left_sidebar.css

@@ -244,7 +244,7 @@ li.show-more-topics {
             align-items: center;
         }
 
-        #show_all_private_messages {
+        #show-all-direct-messages {
             width: var(--left-sidebar-header-icon-width);
             display: flex;
             align-items: center;

web/templates/left_sidebar.hbs

@@ -149,7 +149,7 @@
                 <i id="toggle-direct-messages-section-icon" class="fa fa-sm fa-caret-down dm-tooltip-target zoom-in-hide" aria-hidden="true" tabindex="0" role="button"></i>
                 <h4 class="left-sidebar-title"><span class="dm-tooltip-target">{{t 'DIRECT MESSAGES' }}</span></h4>
                 <div class="heading-markers-and-controls">
-                    <a id="show_all_private_messages" href="#narrow/is/dm" data-tooltip-template-id="show-all-pms-template">
+                    <a id="show-all-direct-messages" href="#narrow/is/dm" data-tooltip-template-id="show-all-pms-template">
                         <i class="fa fa-align-right" aria-label="{{t 'Direct message feed' }}"></i>
                     </a>
                     <span class="unread_count"></span>