paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_popovers: Convert module to TypeScript.

Browse Source
This commit is contained in:
afeefuddin
2024-06-27 01:49:55 +05:30
committed by Tim Abbott
parent e9bf3825d4
commit cb1c293030
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tools/test-js-with-node
View File

@@ -72,7 +72,7 @@ EXEMPT_FILES = make_set(
"web/src/compose_closed_ui.ts", "web/src/compose_closed_ui.ts",
"web/src/compose_fade.ts", "web/src/compose_fade.ts",
"web/src/compose_notifications.ts", "web/src/compose_notifications.ts",
"web/src/compose_popovers.js", "web/src/compose_popovers.ts",
"web/src/compose_recipient.ts", "web/src/compose_recipient.ts",
"web/src/compose_reply.ts", "web/src/compose_reply.ts",
"web/src/compose_send_menu_popover.js", "web/src/compose_send_menu_popover.js",

8
web/src/compose_popovers.js → web/src/compose_popovers.ts
View File

@@ -1,4 +1,5 @@
import $ from "jquery"; import $ from "jquery";
import assert from "minimalistic-assert";
import * as tippy from "tippy.js"; import * as tippy from "tippy.js";
import render_compose_control_buttons_popover from "../templates/popovers/compose_control_buttons/compose_control_buttons_popover.hbs"; import render_compose_control_buttons_popover from "../templates/popovers/compose_control_buttons/compose_control_buttons_popover.hbs";
@@ -11,7 +12,7 @@ import * as popovers from "./popovers";
import * as rows from "./rows"; import * as rows from "./rows";
import {parse_html} from "./ui_util"; import {parse_html} from "./ui_util";
export function initialize() { export function initialize(): void {
// compose box buttons popover shown on mobile widths. // compose box buttons popover shown on mobile widths.
// We want this click event to propagate and hide other popovers // We want this click event to propagate and hide other popovers
// that could possibly obstruct user from using this popover. // that could possibly obstruct user from using this popover.
@@ -52,7 +53,7 @@ export function initialize() {
// Destroy instance so that event handlers // Destroy instance so that event handlers
// are destroyed too. // are destroyed too.
instance.destroy(); instance.destroy();
popover_menus.popover_instances.compose_mobile_button = undefined; popover_menus.popover_instances.compose_mobile_button = null;
}, },
}); });
@@ -62,6 +63,7 @@ export function initialize() {
popover_menus.register_popover_menu(".compose_control_menu_wrapper", { popover_menus.register_popover_menu(".compose_control_menu_wrapper", {
placement: "top", placement: "top",
onShow(instance) { onShow(instance) {
assert(instance.reference instanceof HTMLElement);
const parent_row = rows.get_closest_row(instance.reference); const parent_row = rows.get_closest_row(instance.reference);
let preview_mode_on; let preview_mode_on;
// If the popover is opened from a message edit form, we want to // If the popover is opened from a message edit form, we want to
@@ -85,7 +87,7 @@ export function initialize() {
}, },
onHidden(instance) { onHidden(instance) {
instance.destroy(); instance.destroy();
popover_menus.popover_instances.compose_control_buttons = undefined; popover_menus.popover_instances.compose_control_buttons = null;
}, },
}); });
} }