paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 14:03:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

streams: Set system_groups_name_dict in add_subscriptions_backend.

Browse Source 
We need system_groups_name_dict in all cases.

Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
This commit is contained in:
apoorvapendse
2025-07-01 14:28:48 +05:30
committed by Tim Abbott
parent e2f3b64b35
commit cb487da45a
1 changed files with 1 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
zerver/views/streams.py
View File

@@ -697,15 +697,11 @@ def add_subscriptions_backend(
anonymous_group_membership = {} anonymous_group_membership = {}
group_settings_map = {} group_settings_map = {}
request_settings_dict = locals() request_settings_dict = locals()
# We don't want to calculate this value if no default values are system_groups_name_dict = get_role_based_system_groups_dict(realm)
# needed.
system_groups_name_dict = None
for setting_name, permission_configuration in Stream.stream_permission_group_settings.items(): for setting_name, permission_configuration in Stream.stream_permission_group_settings.items():
assert setting_name in request_settings_dict assert setting_name in request_settings_dict
if request_settings_dict[setting_name] is not None: if request_settings_dict[setting_name] is not None:
setting_request_value = request_settings_dict[setting_name] setting_request_value = request_settings_dict[setting_name]
if system_groups_name_dict is None:
system_groups_name_dict = get_role_based_system_groups_dict(realm)
setting_value = parse_group_setting_value( setting_value = parse_group_setting_value(
setting_request_value, system_groups_name_dict[SystemGroups.NOBODY] setting_request_value, system_groups_name_dict[SystemGroups.NOBODY]
) )
@@ -718,8 +714,6 @@ def add_subscriptions_backend(
if not isinstance(setting_value, int): if not isinstance(setting_value, int):
anonymous_group_membership[group_settings_map[setting_name].id] = setting_value anonymous_group_membership[group_settings_map[setting_name].id] = setting_value
else: else:
if system_groups_name_dict is None:
system_groups_name_dict = get_role_based_system_groups_dict(realm)
group_settings_map[setting_name] = get_stream_permission_default_group( group_settings_map[setting_name] = get_stream_permission_default_group(
setting_name, system_groups_name_dict, creator=user_profile setting_name, system_groups_name_dict, creator=user_profile
) )