paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Fix broken logic in 'finish' test.

Browse Source 
It doesn't make sense that there would be no compose pill user ids
if there were compose pill emails, and there needs to be permission
to send a direct message or the message won't successfully send.

This was working before because `user_ids_string` ended up empty
in `validate_private_message`, which incorrectly returned true
for `check_dm_permissions_and_get_error_string`.
This commit is contained in:
Evy Kassirer
2025-05-06 15:17:57 +02:00
committed by Tim Abbott
parent b210456e35
commit cbc4dfb086
1 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
web/tests/compose.test.cjs
View File

@@ -48,10 +48,9 @@ const server_events = mock_esm("../src/server_events");
const transmit = mock_esm("../src/transmit");
const upload = mock_esm("../src/upload");
const onboarding_steps = mock_esm("../src/onboarding_steps");
mock_esm("../src/group_permission_settings", {
get_group_permission_setting_config: () => ({
allow_everyone_group: true,
}),
mock_esm("../src/settings_data", {
user_has_permission_for_group_setting: () => true,
user_can_access_all_other_users: () => true,
});
const compose_ui = zrequire("compose_ui");
@@ -519,9 +518,9 @@ test_ui("finish", ({override, override_rewire}) => {
override_rewire(compose_ui, "compose_spinner_visible", false);
compose_state.set_message_type("private");
override(compose_pm_pill, "get_emails", () => "bob@example.com");
override(compose_pm_pill, "get_user_ids", () => []);
override(realm, "realm_direct_message_permission_group", nobody.id);
override(compose_pm_pill, "get_emails", () => bob.email);
override(compose_pm_pill, "get_user_ids", () => [bob.user_id]);
override(realm, "realm_direct_message_permission_group", everyone.id);
override(realm, "realm_direct_message_initiator_group", everyone.id);
let compose_finished_event_checked = false;