paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

mypy: Use better types for EVENT_FUNCTION_MAPPER.

Browse Source 
The EVENT_FUNCTION_MAPPER maps a string event name
to a function handler.  Before this we circumvented
mypy checks with a call to get_body_function_based_on_type,
which specified Any as the type of our event function.

Now the types are rigorous.

This change was impossible without the recent commit
to introduce the Helper class.
This commit is contained in:
Steve Howell
2020-09-01 16:25:17 +00:00
committed by Tim Abbott
parent 4de2b78c25
commit cc2dbefc60
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
zerver/webhooks/github/view.py
View File

@@ -1,6 +1,6 @@
import re
from functools import partial
from typing import Any, Dict, Optional
from typing import Any, Callable, Dict, Optional
from django.http import HttpRequest, HttpResponse
@@ -515,7 +515,7 @@ def get_subject_based_on_type(payload: Dict[str, Any], event: str) -> str:
return get_repository_name(payload)
EVENT_FUNCTION_MAPPER = {
EVENT_FUNCTION_MAPPER: Dict[str, Callable[[Helper], str]] = {
'commit_comment': get_commit_comment_body,
'closed_pull_request': get_closed_pull_request_body,
'create': partial(get_create_or_delete_body, action='created'),
@@ -605,7 +605,7 @@ def api_github_webhook(
subject = get_subject_based_on_type(payload, event)
body_function = get_body_function_based_on_type(event)
body_function = EVENT_FUNCTION_MAPPER[event]
helper = Helper(
payload=payload,
@@ -671,6 +671,3 @@ def get_zulip_event_name(
complete_event = "{}:{}".format(header_event, payload.get("action", "???")) # nocoverage
raise UnexpectedWebhookEventType('GitHub', complete_event)
def get_body_function_based_on_type(type: str) -> Any:
return EVENT_FUNCTION_MAPPER.get(type)