paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 05:23:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

zjquery: Rename add_child() to set_find_results().

Browse Source 
Hopefully this will make it more explicit that zjquery does
not truly simulate DOM, but it instead allows you to dynamically
set what you want the results of $('foo').find(some_selector)
to be.
This commit is contained in:
Steve Howell
2017-07-08 08:31:18 -04:00
parent 70407e080d
commit ccd821e29b
7 changed files with 49 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
frontend_tests/node_tests/reactions.js
View File

@@ -146,7 +146,7 @@ set_global('message_store', {
var count_element = $('count-stub');
var reaction_element = $('reaction-stub');
reaction_element.add_child('.message_reaction_count', count_element);
reaction_element.set_find_results('.message_reaction_count', count_element);
reactions.set_reaction_count(reaction_element, 5);
@@ -158,8 +158,8 @@ set_global('message_store', {
var message_row = $('some-message-row');
var message_reactions = $('our-reactions-section');
message_table.add_child("[zid='555']", message_row);
message_row.add_child('.message_reactions', message_reactions);
message_table.set_find_results("[zid='555']", message_row);
message_row.set_find_results('.message_reactions', message_reactions);
var section = reactions.get_reaction_section(555);
@@ -222,7 +222,7 @@ set_global('message_store', {
var count_element = $('count-element');
var reaction_element = $('reaction-element');
reaction_element.add_child('.message_reaction_count', count_element);
reaction_element.set_find_results('.message_reaction_count', count_element);
var title_set;
reaction_element.prop = function (prop_name, value) {