diff --git a/zerver/lib/bugdown/__init__.py b/zerver/lib/bugdown/__init__.py index bd1c9a8941..df013ab44b 100644 --- a/zerver/lib/bugdown/__init__.py +++ b/zerver/lib/bugdown/__init__.py @@ -1877,7 +1877,7 @@ def get_email_info(realm_id: int, emails: Set[str]) -> Dict[str, FullNameInfo]: } return dct -def get_full_name_info(realm_id: int, full_names: Set[str]) -> Dict[str, FullNameInfo]: +def get_possible_mentions_info(realm_id: int, full_names: Set[str]) -> Dict[str, FullNameInfo]: if not full_names: return dict() @@ -1916,7 +1916,7 @@ def get_full_name_info(realm_id: int, full_names: Set[str]) -> Dict[str, FullNam class MentionData: def __init__(self, realm_id: int, content: str) -> None: full_names = possible_mentions(content) - self.full_name_info = get_full_name_info(realm_id, full_names) + self.full_name_info = get_possible_mentions_info(realm_id, full_names) self.user_id_info = { row['id']: row for row in self.full_name_info.values() diff --git a/zerver/tests/test_bugdown.py b/zerver/tests/test_bugdown.py index 51373cd6b1..0c651a54d9 100644 --- a/zerver/tests/test_bugdown.py +++ b/zerver/tests/test_bugdown.py @@ -176,7 +176,7 @@ class BugdownMiscTest(ZulipTestCase): expected_diff = "\u001b[34m-\u001b[0m

The \u001b[33mquick brown\u001b[0m fox jumps over the lazy dog. Animal stories are fun\u001b[31m, yeah\u001b[0m

\n\u001b[34m+\u001b[0m

The \u001b[33mfast\u001b[0m fox jumps over the lazy dog\u001b[32ms and cats\u001b[0m. Animal stories are fun

\n" self.assertEqual(mdiff.diff_strings(str1, str2), expected_diff) - def test_get_full_name_info(self) -> None: + def test_get_possible_mentions_info(self) -> None: realm = get_realm('zulip') def make_user(email: str, full_name: str) -> UserProfile: @@ -201,7 +201,7 @@ class BugdownMiscTest(ZulipTestCase): fred4 = make_user('fred4@example.com', 'Fred Flintstone') fred4_key = 'fred flintstone|{}'.format(fred4.id) - dct = bugdown.get_full_name_info(realm.id, {'Fred Flintstone', 'cordelia LEAR', 'Not A User'}) + dct = bugdown.get_possible_mentions_info(realm.id, {'Fred Flintstone', 'cordelia LEAR', 'Not A User'}) self.assertEqual(set(dct.keys()), {'fred flintstone', fred4_key, 'cordelia lear'}) self.assertEqual(dct['fred flintstone'], dict( email='fred2@example.com',