paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-01 20:44:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_fetch: Track history_limited property.

Browse Source
This commit is contained in:
Tim Abbott
2018-12-12 15:53:35 -08:00
parent b8a45d889e
commit cd118bbc7e
3 changed files with 31 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
frontend_tests/node_tests/fetch_status.js
View File

@@ -30,6 +30,14 @@ function has_not_found_newest() {
assert.equal(fetch_status.has_found_newest(), false);
}
function can_load_history() {
assert.equal(fetch_status.history_limited(), false);
}
function blocked_history() {
assert.equal(fetch_status.history_limited(), true);
}
run_test('basics', () => {
reset();
@@ -37,16 +45,19 @@ run_test('basics', () => {
blocked_newer();
blocked_older();
can_load_history();
has_not_found_newest();
fetch_status.finish_initial_narrow({
found_oldest: true,
found_newest: true,
history_limited: true,
});
has_found_newest();
blocked_newer();
blocked_older();
blocked_history();
reset();
@@ -54,14 +65,17 @@ run_test('basics', () => {
blocked_newer();
blocked_older();
can_load_history();
fetch_status.finish_initial_narrow({
found_oldest: false,
found_newest: false,
history_limited: false,
});
can_load_older();
can_load_newer();
can_load_history();
reset();
@@ -71,25 +85,31 @@ run_test('basics', () => {
blocked_older();
can_load_newer();
can_load_history();
fetch_status.finish_older_batch({
found_oldest: false,
history_limited: false,
});
can_load_older();
can_load_newer();
can_load_history();
fetch_status.start_older_batch();
blocked_older();
can_load_newer();
can_load_history();
fetch_status.finish_older_batch({
found_oldest: true,
history_limited: true,
});
blocked_older();
can_load_newer();
blocked_history();
reset();

7
static/js/fetch_status.js
View File

@@ -6,6 +6,7 @@ var FetchStatus = function () {
var loading_newer = false;
var found_oldest = false;
var found_newest = false;
var history_limited = false;
self.start_initial_narrow = function () {
loading_newer = true;
@@ -17,6 +18,7 @@ var FetchStatus = function () {
loading_older = false;
found_oldest = opts.found_oldest;
found_newest = opts.found_newest;
history_limited = opts.history_limited;
};
self.start_older_batch = function () {
@@ -26,12 +28,17 @@ var FetchStatus = function () {
self.finish_older_batch = function (opts) {
loading_older = false;
found_oldest = opts.found_oldest;
history_limited = opts.history_limited;
};
self.can_load_older_messages = function () {
return !loading_older && !found_oldest;
};
self.history_limited = function () {
return history_limited;
};
self.start_newer_batch = function () {
loading_newer = true;
};

4
static/js/message_fetch.js
View File

@@ -226,10 +226,12 @@ exports.do_backfill = function (opts) {
cont: function (data) {
msg_list.fetch_status.finish_older_batch({
found_oldest: data.found_oldest,
history_limited: data.history_limited,
});
if (msg_list === home_msg_list) {
message_list.all.fetch_status.finish_older_batch({
found_oldest: data.found_oldest,
history_limited: data.history_limited,
});
}
if (opts.cont) {
@@ -306,9 +308,11 @@ exports.initialize = function () {
// has an older batch to finish.
home_msg_list.fetch_status.finish_older_batch({
found_oldest: data.found_oldest,
history_limited: data.history_limited,
});
message_list.all.fetch_status.finish_older_batch({
found_oldest: data.found_oldest,
history_limited: data.history_limited,
});
}