paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-17 12:21:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

group-settings: Refactor code to set up permission setting widgets.

Browse Source 
This commit refactors code to set up permission setting widgets
by looping over list of settings.
This commit is contained in:
Sahil Batra
2024-11-18 19:37:42 +05:30
committed by Tim Abbott
parent 3af84d6e69
commit cde4c335b1
3 changed files with 44 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
web/src/user_group_edit.js
View File

@@ -154,35 +154,15 @@ function show_membership_settings(group) {
}
function show_general_settings(group) {
settings_components.create_group_setting_widget({
$pill_container: $("#id_can_add_members_group"),
setting_name: "can_add_members_group",
group,
});
const permission_settings = Object.keys(realm.server_supported_permission_settings.group);
for (const setting_name of permission_settings) {
settings_components.create_group_setting_widget({
$pill_container: $(`#id_${CSS.escape(setting_name)}`),
setting_name,
group,
});
}
settings_components.create_group_setting_widget({
$pill_container: $("#id_can_manage_group"),
setting_name: "can_manage_group",
group,
});
settings_components.create_group_setting_widget({
$pill_container: $("#id_can_join_group"),
setting_name: "can_join_group",
group,
});
settings_components.create_group_setting_widget({
$pill_container: $("#id_can_leave_group"),
setting_name: "can_leave_group",
group,
});
settings_components.create_group_setting_widget({
$pill_container: $("#id_can_mention_group"),
setting_name: "can_mention_group",
group,
});
update_general_panel_ui(group);
}