paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

GoogleOAuthTest: Include the /accounts/login/google/ step in tests.

Browse Source 
This makes our Google auth tests a bit more faithful, in that they now
follow the full Oauth flow, rather than skipping the first step.
This commit is contained in:
Tim Abbott
2017-04-27 16:18:57 -07:00
parent 8b78f22660
commit ce33368905
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
zerver/tests/test_auth_backends.py
View File

@@ -662,14 +662,21 @@ class ResponseMock(object):
class GoogleOAuthTest(ZulipTestCase):
def google_oauth2_test(self, token_response, account_response, subdomain=None):
# type: (ResponseMock, ResponseMock, Optional[str]) -> HttpResponse
url = "/accounts/login/google/send/"
url = "/accounts/login/google/"
params = {}
headers = {}
if subdomain is not None:
params['subdomain'] = subdomain
headers['HTTP_HOST'] = subdomain + ".testserver"
if len(params) > 0:
url += "?%s" % (urllib.parse.urlencode(params))
result = self.client_get(url)
result = self.client_get(url, **headers)
self.assertEqual(result.status_code, 302)
if '/accounts/login/google/send/' not in result.url:
return result
# Now do the /google/send/ request
result = self.client_get(result.url)
self.assertEqual(result.status_code, 302)
if 'google' not in result.url:
return result