mirror of
https://github.com/zulip/zulip.git
synced 2025-11-17 20:41:46 +00:00
Sweep tests for expected_subject -> expected_topic.
This is all in the webhooks tests, including some docs for how to write those tests.
This commit is contained in:
@@ -12,19 +12,19 @@ class HelloWorldHookTests(WebhookTestCase):
|
||||
|
||||
# Note: Include a test function per each distinct message condition your integration supports
|
||||
def test_hello_message(self) -> None:
|
||||
expected_subject = u"Hello World"
|
||||
expected_topic = u"Hello World"
|
||||
expected_message = u"Hello! I am happy to be here! :smile:\nThe Wikipedia featured article for today is **[Marilyn Monroe](https://en.wikipedia.org/wiki/Marilyn_Monroe)**"
|
||||
|
||||
# use fixture named helloworld_hello
|
||||
self.send_and_test_stream_message('hello', expected_subject, expected_message,
|
||||
self.send_and_test_stream_message('hello', expected_topic, expected_message,
|
||||
content_type="application/x-www-form-urlencoded")
|
||||
|
||||
def test_goodbye_message(self) -> None:
|
||||
expected_subject = u"Hello World"
|
||||
expected_topic = u"Hello World"
|
||||
expected_message = u"Hello! I am happy to be here! :smile:\nThe Wikipedia featured article for today is **[Goodbye](https://en.wikipedia.org/wiki/Goodbye)**"
|
||||
|
||||
# use fixture named helloworld_goodbye
|
||||
self.send_and_test_stream_message('goodbye', expected_subject, expected_message,
|
||||
self.send_and_test_stream_message('goodbye', expected_topic, expected_message,
|
||||
content_type="application/x-www-form-urlencoded")
|
||||
|
||||
def test_pm_to_bot_owner(self) -> None:
|
||||
@@ -48,11 +48,11 @@ class HelloWorldHookTests(WebhookTestCase):
|
||||
|
||||
def test_custom_topic(self) -> None:
|
||||
# Note that this is really just a test for check_send_webhook_message
|
||||
expected_subject = u"Custom Topic"
|
||||
self.url = self.build_webhook_url(topic=expected_subject)
|
||||
expected_topic = u"Custom Topic"
|
||||
self.url = self.build_webhook_url(topic=expected_topic)
|
||||
expected_message = u"Hello! I am happy to be here! :smile:\nThe Wikipedia featured article for today is **[Goodbye](https://en.wikipedia.org/wiki/Goodbye)**"
|
||||
|
||||
self.send_and_test_stream_message('goodbye', expected_subject, expected_message,
|
||||
self.send_and_test_stream_message('goodbye', expected_topic, expected_message,
|
||||
content_type="application/x-www-form-urlencoded")
|
||||
|
||||
def get_body(self, fixture_name: str) -> str:
|
||||
|
||||
Reference in New Issue
Block a user