From cf658155e79518dd38b8fd82d2524f27a4b66696 Mon Sep 17 00:00:00 2001 From: opmkumar Date: Wed, 22 Jan 2025 00:03:47 +0530 Subject: [PATCH] left_sidebar: Remove logic of hiding unread counter of STREAMS header. This removes the previous logic where the STREAMS header unread counter was hidden when "Show unread counts for" was set to "No streams." --- web/src/stream_list.ts | 6 ------ web/styles/left_sidebar.css | 29 ----------------------------- web/templates/left_sidebar.hbs | 2 +- 3 files changed, 1 insertion(+), 36 deletions(-) diff --git a/web/src/stream_list.ts b/web/src/stream_list.ts index f99a40d5a7..ac35fe15fb 100644 --- a/web/src/stream_list.ts +++ b/web/src/stream_list.ts @@ -644,12 +644,6 @@ export function update_dom_with_unread_counts(counts: FullUnreadCountsData): voi } export function update_dom_unread_counts_visibility(): void { - const $streams_header = $("#streams_header"); - if (settings_data.should_mask_unread_count(false)) { - $streams_header.addClass("hide_unread_counts"); - } else { - $streams_header.removeClass("hide_unread_counts"); - } for (const stream of stream_sidebar.rows.values()) { const $subscription_block = stream.get_li().find(".subscription_block"); diff --git a/web/styles/left_sidebar.css b/web/styles/left_sidebar.css index b697ad9cb5..bda2028b55 100644 --- a/web/styles/left_sidebar.css +++ b/web/styles/left_sidebar.css @@ -1785,35 +1785,6 @@ li.topic-list-item { grid-area: filter-box; padding-right: var(--line-height-sidebar-row-prominent); } - - &.hide_unread_counts { - .unread_count, - .unread_count.hide, - .masked_unread_count { - display: none; - } - - /* When an empty unread count is hidden, - hide the masked unread count, too. */ - .unread_count.hide + .masked_unread_count { - display: none; - } - - .masked_unread_count { - display: flex; - } - - &:hover { - .unread_count { - display: block; - } - - .hide, - .masked_unread_count { - display: none; - } - } - } } .stream_search_section, diff --git a/web/templates/left_sidebar.hbs b/web/templates/left_sidebar.hbs index 93876626a0..8eb92db893 100644 --- a/web/templates/left_sidebar.hbs +++ b/web/templates/left_sidebar.hbs @@ -177,7 +177,7 @@
-
+