paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

list_render: Add replace_list_data().

Browse Source 
The data() function was used in only one place,
and it can be replaced now with two simple
lines of code.
This commit is contained in:
Steve Howell
2020-04-14 23:29:34 +00:00
committed by Tim Abbott
parent d406df75b3
commit cf741e9a11
3 changed files with 12 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
static/js/list_render.js
View File

@@ -128,32 +128,6 @@ exports.create = function ($container, list, opts) {
meta.offset += load_count;
};
// reset the data associated with a list. This is so that instead of
// initializing a new progressive list render instance, you can just
// update the data of an existing one.
widget.data = function (...args) {
// if no args are provided then just return the existing data.
// this interface is similar to how many jQuery functions operate,
// where a call to the method without data returns the existing data.
if (args.length === 0) {
return meta.list;
}
const [data] = args;
if (Array.isArray(data)) {
meta.list = data;
meta.filtered_list = data;
widget.filter_and_sort();
widget.clear();
return;
}
blueslip.warn("The data object provided to the progressive" +
" list render is invalid");
};
widget.clear = function () {
$container.html("");
meta.offset = 0;
@@ -245,6 +219,16 @@ exports.create = function ($container, list, opts) {
}
};
widget.replace_list_data = function (list) {
/*
We mostly use this widget for lists where you are
not adding or removing rows, so when you do modify
the list, we have a brute force solution.
*/
meta.list = list;
widget.hard_redraw();
};
// add built-in generic sort functions.
widget.add_generic_sort_function("alphabetic", function (prop) {
return function (a, b) {