paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Rename classes for display settings elements.

Browse Source 
We rename the class of display setting elements by prefixing
them with 'setting_' for clarity.
This commit is contained in:
Sahil Batra
2021-08-10 13:05:20 +05:30
committed by Tim Abbott
parent 9c17e7019d
commit d05730a199
4 changed files with 28 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
frontend_tests/puppeteer_tests/settings.ts
View File

@@ -299,8 +299,8 @@ async function test_alert_words_section(page: Page): Promise<void> {
}
async function change_language(page: Page, language_data_code: string): Promise<void> {
await page.waitForSelector("#user-display-settings .default_language", {visible: true});
await page.click("#user-display-settings .default_language");
await page.waitForSelector("#user-display-settings .setting_default_language", {visible: true});
await page.click("#user-display-settings .setting_default_language");
await page.waitForSelector("#user_default_language_modal", {visible: true});
const language_selector = `a[data-code="${CSS.escape(language_data_code)}"]`;
await page.click(language_selector);
@@ -313,10 +313,10 @@ async function check_language_setting_status(page: Page): Promise<void> {
}
async function assert_language_changed_to_chinese(page: Page): Promise<void> {
await page.waitForSelector("#user-display-settings .default_language", {visible: true});
await page.waitForSelector("#user-display-settings .setting_default_language", {visible: true});
const default_language = await common.get_text_from_selector(
page,
"#user-display-settings .default_language",
"#user-display-settings .setting_default_language",
);
assert.strictEqual(
default_language,
@@ -342,7 +342,7 @@ async function test_default_language_setting(page: Page): Promise<void> {
// Check that the saved indicator appears
await check_language_setting_status(page);
await page.click(".reload_link");
await page.waitForSelector("#user-display-settings .default_language", {visible: true});
await page.waitForSelector("#user-display-settings .setting_default_language", {visible: true});
await assert_language_changed_to_chinese(page);
await test_i18n_language_precedence(page);
await page.waitForSelector(display_settings_section, {visible: true});
@@ -357,7 +357,7 @@ async function test_default_language_setting(page: Page): Promise<void> {
await page.waitForSelector(display_settings_section, {visible: true});
await page.click(display_settings_section);
await page.waitForSelector("#user-display-settings .language-settings-status", {visible: true});
await page.waitForSelector("#user-display-settings .default_language", {visible: true});
await page.waitForSelector("#user-display-settings .setting_default_language", {visible: true});
}
async function test_notifications_section(page: Page): Promise<void> {