paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Add backend to change allow_edit_history to integer field.

Browse Source 
This commit implements the backend of migrating the
`allow_edit_history` setting to
`message_edit_history_visibility_policy`.
This allows organizations, to have an intermediate setting to
view only the "Moves" history of the messages.

We still pass `realm_allow_edit_history` in `/register` response
though for older clients with its value being set depending on the
value of `realm_message_edit_history_visibility_policy`. We set
`realm_allow_edit_history` to `False` if the
`realm_message_edit_history_visibility_policy` is "None", and
`True` for "Moves only" or "All" message edit history.

Fixes part of #21398.

Co-authored-by: Shlok Patel <shlokcpatel2001@gmail.com>
Co-authored-by: Tim Abbott <tabbott@zulip.com>
This commit is contained in:
Saubhagya Patel
2025-02-25 23:27:00 +05:30
committed by Tim Abbott
parent d9589eba2c
commit d0c5c1cacb
21 changed files with 446 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
zerver/tests/test_events.py
View File

@@ -9,6 +9,7 @@ import time
from collections.abc import Iterator
from contextlib import contextmanager
from datetime import timedelta
from enum import Enum
from io import StringIO
from typing import Any
from unittest import mock
@@ -3846,6 +3847,7 @@ class RealmPropertyActionTest(BaseAction):
default_language=["es", "de", "en"],
description=["Realm description", "New description"],
digest_weekday=[0, 1, 2],
message_edit_history_visibility_policy=Realm.MESSAGE_EDIT_HISTORY_VISIBILITY_POLICY_TYPES,
message_retention_days=[10, 20],
name=["Zulip", "New Name"],
waiting_period_threshold=[1000, 2000],
@@ -3875,7 +3877,9 @@ class RealmPropertyActionTest(BaseAction):
do_set_realm_property(self.user_profile.realm, name, vals[0], acting_user=self.user_profile)
if vals[0] != original_val:
if vals[0] != original_val and not (
isinstance(vals[0], Enum) and vals[0].value == original_val
):
self.assertEqual(
RealmAuditLog.objects.filter(
realm=self.user_profile.realm,
@@ -3885,11 +3889,18 @@ class RealmPropertyActionTest(BaseAction):
).count(),
1,
)
for count, val in enumerate(vals[1:]):
for count, raw_value in enumerate(vals[1:]):
now = timezone_now()
state_change_expected = True
old_value = vals[count]
num_events = 1
raw_old_value = vals[count]
if isinstance(raw_value, Enum):
value = raw_value.value
old_value = raw_old_value.value
else:
value = raw_value
old_value = raw_old_value
with self.verify_action(
state_change_expected=state_change_expected, num_events=num_events
@@ -3897,7 +3908,7 @@ class RealmPropertyActionTest(BaseAction):
do_set_realm_property(
self.user_profile.realm,
name,
val,
raw_value,
acting_user=self.user_profile,
)
@@ -3909,7 +3920,7 @@ class RealmPropertyActionTest(BaseAction):
acting_user=self.user_profile,
extra_data={
RealmAuditLog.OLD_VALUE: old_value,
RealmAuditLog.NEW_VALUE: val,
RealmAuditLog.NEW_VALUE: value,
"property": name,
},
).count(),