paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

bootstrap_typeahead: Fix compose typeahead overflowing when expanded.

Browse Source 
When compose box is expanded, typeahead overlfows the top of the window.
We move the typeahead to the bottom of the screen and let
preventOverflow shift it into the visible area.
This commit is contained in:
Aman Agrawal
2024-05-07 15:15:50 +05:30
committed by Tim Abbott
parent 4e87f35c7d
commit d1050376e1
4 changed files with 56 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/compose_ui.ts
View File

@@ -10,6 +10,7 @@ import {
wrapFieldSelection,
} from "text-field-edit";
import type {Typeahead} from "./bootstrap_typeahead";
import * as bulleted_numbered_list_util from "./bulleted_numbered_list_util";
import * as common from "./common";
import {$t} from "./i18n";
@@ -58,8 +59,13 @@ type SelectedLinesSections = {
export let compose_spinner_visible = false;
export let shift_pressed = false; // true or false
export let code_formatting_button_triggered = false; // true or false
export let compose_textarea_typeahead: Typeahead<object> | undefined;
let full_size_status = false; // true or false
export function set_compose_textarea_typeahead(typeahead: Typeahead<object>): void {
compose_textarea_typeahead = typeahead;
}
export function set_code_formatting_button_triggered(value: boolean): void {
code_formatting_button_triggered = value;
}
@@ -67,6 +73,10 @@ export function set_code_formatting_button_triggered(value: boolean): void {
// Some functions to handle the full size status explicitly
export function set_full_size(is_full: boolean): void {
full_size_status = is_full;
// Show typeahead at bottom of textarea on compose full size.
if (compose_textarea_typeahead) {
compose_textarea_typeahead.dropup = !is_full;
}
}
export function is_full_size(): boolean {