paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

popover_menus: Fix tippy instance being undefined.

Browse Source 
Since the reference element can be removed from DOM, we rely on
`popper` here to access the tippy instance which is reliable.
This commit is contained in:
Aman Agrawal
2025-03-18 17:58:27 +05:30
committed by Tim Abbott
parent 1314aec7e1
commit d14b1b1085
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/popover_menus.ts
View File

@@ -212,8 +212,10 @@ export const default_popover_props: Partial<tippy.Props> = {
phase: "beforeWrite", phase: "beforeWrite",
requires: ["$$tippy"], requires: ["$$tippy"],
fn({state}) { fn({state}) {
// Since the reference element can be removed from DOM, we rely on popper
// here to access the tippy instance which is reliable.
// eslint-disable-next-line @typescript-eslint/consistent-type-assertions // eslint-disable-next-line @typescript-eslint/consistent-type-assertions
const instance = (state.elements.reference as tippy.ReferenceElement)._tippy!; const instance = (state.elements.popper as tippy.PopperElement)._tippy!;
const $popover = $(state.elements.popper); const $popover = $(state.elements.popper);
const $tippy_box = $popover.find(".tippy-box"); const $tippy_box = $popover.find(".tippy-box");
// $tippy_box[0].hasAttribute("data-reference-hidden"); is the real check // $tippy_box[0].hasAttribute("data-reference-hidden"); is the real check