paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 20:02:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

app_components: Refactor table-striped border color rule.

Browse Source 
This commit fix the regression for tables at uses the
.table-striped css, which are primarily used at the
settings menu.

In #29859, we began organizing CSS into more specific
variables and selector, which led to the deprecation of
several general CSS rules that affected these tables.

The fix switches the border-color value used by the
.table-striped css rules to a new CSS variable that
contains both dark and light theme values.

Fixes #30449
This commit is contained in:
PieterCK
2024-06-17 12:54:17 +07:00
committed by Tim Abbott
parent 9c3e03ba83
commit d16ae00b15
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/styles/app_components.css
View File

@@ -794,7 +794,7 @@ div.overlay {
} }
& td { & td {
border-top: 1px solid hsl(0deg 0% 87%); border-top: 1px solid var(--color-border-table-striped);
} }
} }

8
web/styles/app_variables.css
View File

@@ -388,6 +388,9 @@
--color-border-rendered-markdown-table: hsl(0deg 0% 80%); --color-border-rendered-markdown-table: hsl(0deg 0% 80%);
--color-border-informational-overlays-table: hsl(0deg 0% 87%); --color-border-informational-overlays-table: hsl(0deg 0% 87%);
/* Settings table colors */
--color-border-table-striped: hsl(0deg 0% 87%);
/* Markdown code colors */ /* Markdown code colors */
--color-markdown-code-text: hsl(0deg 0% 0%); --color-markdown-code-text: hsl(0deg 0% 0%);
--color-markdown-code-background: hsl(0deg 0% 0% / 6%); --color-markdown-code-background: hsl(0deg 0% 0% / 6%);
@@ -739,11 +742,14 @@
--color-text-url-hover: hsl(200deg 79% 66%); --color-text-url-hover: hsl(200deg 79% 66%);
--color-text-settings-field-hint: hsl(0deg 0% 52%); --color-text-settings-field-hint: hsl(0deg 0% 52%);
/* Markdown color */ /* Markdown colors */
--color-background-rendered-markdown-thead: hsl(0deg 0% 0% / 50%); --color-background-rendered-markdown-thead: hsl(0deg 0% 0% / 50%);
--color-border-rendered-markdown-table: hsl(0deg 0% 100% / 20%); --color-border-rendered-markdown-table: hsl(0deg 0% 100% / 20%);
--color-border-informational-overlays-table: hsl(0deg 0% 0% / 20%); --color-border-informational-overlays-table: hsl(0deg 0% 0% / 20%);
/* Settings table colors */
--color-border-table-striped: hsl(0deg 0% 0% / 20%);
/* Markdown code colors */ /* Markdown code colors */
/* Note that Markdown code-link colors are identical /* Note that Markdown code-link colors are identical
to light theme, and so are not redeclared here. */ to light theme, and so are not redeclared here. */