paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Remove realm-level default of enable_login_emails setting.

Browse Source 
This commit does not remove the 'enable_login_emails' field from
RealmUserDefault table but it is just not used and cannot be
changed from UI or API similar to 'enable_marketing_emails' setting.
This commit is contained in:
Sahil Batra
2021-09-28 13:33:43 +05:30
committed by Tim Abbott
parent 8b638648dc
commit d1732fb9da
6 changed files with 10 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
static/js/admin.js
View File

@@ -62,12 +62,10 @@ function get_realm_level_notification_settings(options) {
realm_user_settings_defaults,
);
// We remove enable_marketing_emails setting from all_notification_settings, since there is no
// realm-level default of this setting.
all_notifications_settings.settings.other_email_settings = [
"enable_digest_emails",
"enable_login_emails",
];
// We remove enable_marketing_emails and enable_login_emails
// setting from all_notification_settings, since there are no
// realm-level defaults for these setting.
all_notifications_settings.settings.other_email_settings = ["enable_digest_emails"];
options.general_settings = all_notifications_settings.general_settings;
options.notification_settings = all_notifications_settings.settings;

3
static/js/settings_config.ts
View File

@@ -406,9 +406,6 @@ export const realm_user_settings_defaults_labels = {
defaultMessage: "Send mobile notifications even if user is online (useful for testing)",
}),
enable_digest_emails: $t({defaultMessage: "Send digest emails when user is away"}),
enable_login_emails: $t({
defaultMessage: "Send email notifications for new logins to the account",
}),
realm_presence_enabled: $t({defaultMessage: "Display availability to other users when online"}),
realm_enter_sends: $t({defaultMessage: "Enter sends when composing a message"}),