From d28d9fec0dc820d559e219a74b4781b9657f749b Mon Sep 17 00:00:00 2001 From: Shubham Padia Date: Tue, 16 Apr 2024 15:50:19 +0530 Subject: [PATCH] custom_profile_fields: Refactor toggle display_in_profile_summary. Do not send unnecessary extra params when changing the value of display_in_profile_summary. Instead of searching realm.custom_profile_fields for the field we are editing, we will just use the checkbox value to update the field value, since we don't need to send other params like `name`, `hint`, etc. to the API after API feature level 252 update. --- web/src/settings_profile_fields.js | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/web/src/settings_profile_fields.js b/web/src/settings_profile_fields.js index e1f4b443a3..2ce55c255a 100644 --- a/web/src/settings_profile_fields.js +++ b/web/src/settings_profile_fields.js @@ -581,19 +581,9 @@ function update_profile_fields_checkboxes() { function toggle_display_in_profile_summary_profile_field(e) { const field_id = Number.parseInt($(e.currentTarget).attr("data-profile-field-id"), 10); - const field = get_profile_field(field_id); - - let field_data; - if (field.field_data) { - field_data = field.field_data; - } const data = { - name: field.name, - hint: field.hint, - field_data, - display_in_profile_summary: !field.display_in_profile_summary, - required: field.required, + display_in_profile_summary: $(e.currentTarget).prop("checked"), }; const $profile_field_status = $("#admin-profile-field-status").expectOne();